From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1XdulQ-0002pj-JA
	for ptxdist@pengutronix.de; Tue, 14 Oct 2014 07:35:16 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1XdulQ-0005nX-Gu
	for ptxdist@pengutronix.de; Tue, 14 Oct 2014 07:35:16 +0200
Date: Tue, 14 Oct 2014 07:35:16 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20141014053516.GB3143@pengutronix.de>
References: <1413090574-30326-1-git-send-email-jon@ringle.org>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1413090574-30326-1-git-send-email-jon@ringle.org>
Subject: Re: [ptxdist] [PATCH] ptxdist: unset: env: remove func
 prefix/suffix added by shellshock
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Sun, Oct 12, 2014 at 01:09:34AM -0400, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
> 

I've pushed a different patch that uses the builtin 'export' to get the
list. My hope is, that it will hide any changes like this in the future.

Michael

> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
>  bin/ptxdist | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/bin/ptxdist b/bin/ptxdist
> index f823ebe..10fc492 100755
> --- a/bin/ptxdist
> +++ b/bin/ptxdist
> @@ -2146,8 +2146,15 @@ setup_env() {
>  	whitelist="${*}"
>  	whitelist="${whitelist:+|}${whitelist// /|}"
>  
> +	ptx_test_func_env_name(){ :; }
> +	export -f ptx_test_func_env_name
> +	func_env_name=$(/usr/bin/env | grep ptx_test_func_env_name|cut -f1 -d=)
> +	func_prefix=${func_env_name/ptx_test_func_env_name*}
> +	func_suffix=${func_env_name/*ptx_test_func_env_name}
> +
>  	unset $(/usr/bin/env | \
>  		sed -n -e "s/^\([^=[:space:]]\+\)=.*$/\1/p" | \
> +		sed -e "s/^${func_prefix}\(.*\)${func_suffix}$/\1/g" | \
>  		egrep -v "^(PTXDIST_PTXRC|PTX_AUTOBUILD_DESTDIR|CCACHE_.*|PWD|HOME|USER|PATH|TERM|COLUMNS|LINES|DISPLAY|TMPDIR|http_proxy|https_proxy|ftp_proxy|no_proxy${whitelist})$" )
>  
>  	######## the environment is clean now ########
> -- 
> 1.8.5.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de