From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1XZLZa-000647-Kt
	for ptxdist@pengutronix.de; Wed, 01 Oct 2014 17:12:10 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1XZLZa-0007cB-JP
	for ptxdist@pengutronix.de; Wed, 01 Oct 2014 17:12:10 +0200
Date: Wed, 1 Oct 2014 17:12:10 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20141001151210.GL16481@pengutronix.de>
References: <1412010731-18154-1-git-send-email-apr@cn-eng.de>
	<20141001102934.GE16481@pengutronix.de>
	<1412173521.13601.47.camel@ws-apr.office.loc>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1412173521.13601.47.camel@ws-apr.office.loc>
Subject: Re: [ptxdist] [PATCH] openocd: new package for openocd-0.8.0 (host,
 target)
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Wed, Oct 01, 2014 at 04:25:21PM +0200, Andreas Pretzsch wrote:
> > > +#	@$(call install_tree, openocd, 0, 0, -, /usr/share/openocd/)
> > 
> > don't add comments like this either remove this or actually install any
> > useful files.
> 
> >From your other reply:
> > > +	@$(call install_copy, openocd, 0, 0, 0755, -, /usr/bin/openocd)
> > > > +#	@$(call install_tree, openocd, 0, 0, -, /usr/share/openocd/)
> > > 
> > > Intentionally disabled. 700kB generic extra data on the target makes no
> > > sense. I doubt there won't be one real use case where the makefile is
> > > not pulled into platform local rules and adapted to copy only the 5
> > > relevant files from this tree. So this is more of a reminder where to
> > > look, so I kept is as comment.
> > 
> > I missed this when I commented the patch. Are there any files in
> > /usr/share/openocd/ that are required on the target?
> 
> Not strictly out from there.
> 
> Beside device-specific firmware and examples, it contains some 500
> config files and tcl scripts. Core and SoC specific configs and setups,
> interface (debug adapter) specific configs, RAM and flash layout
> definitions, (eval) board init routines, some helpers, and so on. For
> the myriad targets OpenOCD supports.
> 
> In practice on the target, one will use maybe 5 out of them, sometimes
> even merged into one file, and also adapt it to the specific hardware.
> So a mixture of a few selected ones plus maybe some not even in the
> official package.
> 
> I see no sensible way for a preselection here, and in 99% of the cases,
> it will be project specific. So no pre-install. But I like to keep the
> comment for those who will adapt it to their needs, to ease things.
> 
> What I'll do in v2 is to switch from install_tree to
> install_alternative_tree, missed that one. But still commented out.

Use install_alternative_tree and add an option for it.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de