From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1XYsfn-0004qa-QI
	for ptxdist@pengutronix.de; Tue, 30 Sep 2014 10:20:39 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1XYsfn-00063E-Od
	for ptxdist@pengutronix.de; Tue, 30 Sep 2014 10:20:39 +0200
Date: Tue, 30 Sep 2014 10:20:39 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140930082039.GF24288@pengutronix.de>
References: <1412050724-11845-1-git-send-email-jon@ringle.org>
	<1412050724-11845-2-git-send-email-jon@ringle.org>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1412050724-11845-2-git-send-email-jon@ringle.org>
Subject: Re: [ptxdist] [PATCH 2/2] systemd: PTXCONF_SYSTEMD_COREDUMP
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Tue, Sep 30, 2014 at 12:18:44AM -0400, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
> 
> Allow coredumpctl to be built and installed to debug crashing systemd
> services

Just one comment below. Looks good otherwise.

Michael

> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
>  rules/systemd.in   | 6 ++++++
>  rules/systemd.make | 6 ++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/rules/systemd.in b/rules/systemd.in
> index ba69d8b..b6cdc1b 100644
> --- a/rules/systemd.in
> +++ b/rules/systemd.in
> @@ -81,5 +81,11 @@ config SYSTEMD_TIMEDATE
>  	help
>  	  NTP client for time synchronization and local timezone handling.
>  
> +config SYSTEMD_COREDUMP
> +	bool
> +	prompt "enable generating coredumps"
> +	help
> +	  Enable this only if you need to debug a crashing systemd service
> +
>  endif
>  
> diff --git a/rules/systemd.make b/rules/systemd.make
> index 51ffcac..7173812 100644
> --- a/rules/systemd.make
> +++ b/rules/systemd.make
> @@ -102,7 +102,7 @@ SYSTEMD_CONF_OPT	:= \
>  	--$(call ptx/endis,PTXCONF_SYSTEMD_TIMEDATE)-timedated \
>  	--$(call ptx/endis,PTXCONF_SYSTEMD_TIMEDATE)-timesyncd \
>  	--$(call ptx/endis,PTXCONF_SYSTEMD_LOCALES)-localed \
> -	--disable-coredump \
> +	--$(call ptx/endis,PTXCONF_SYSTEMD_COREDUMP)-coredump \
>  	--disable-polkit \
>  	--$(call ptx/endis,PTXCONF_SYSTEMD_NETWORK)-resolved \
>  	--$(call ptx/endis,PTXCONF_SYSTEMD_NETWORK)-networkd \
> @@ -170,6 +170,7 @@ SYSTEMD_HELPER := \
>  	systemd-bootchart \
>  	systemd-bus-proxyd \
>  	systemd-cgroups-agent \
> +	$(call ptx/ifdef, PTXCONF_SYSTEMD_COREDUMP,systemd-coredump,) \
>  	systemd-fsck \
>  	systemd-hostnamed \
>  	systemd-initctl \
> @@ -309,8 +310,9 @@ endif
>  
>  	@$(call install_copy, systemd, 0, 0, 0755, /var/lib/systemd)
>  
> -#	# systemd expects this directory to exist.
> +ifdef PTXCONF_SYSTEMD_COREDUMP
>  	@$(call install_copy, systemd, 0, 0, 0755, /var/lib/systemd/coredump)
> +endif

Don;t do this. tmpfilesd tries to create this dir even if coredumps are
disabled.

>  
>  	@$(call install_alternative, systemd, 0, 0, 0644, /etc/profile.d/systemd.sh)
>  
> -- 
> 1.8.5.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de