From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1XOOtD-0004mu-0B
	for ptxdist@pengutronix.de; Mon, 01 Sep 2014 12:31:11 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1XOOt6-000317-VN
	for ptxdist@pengutronix.de; Mon, 01 Sep 2014 12:31:04 +0200
Date: Mon, 1 Sep 2014 12:31:04 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140901103104.GD5271@pengutronix.de>
References: <1405936382-6544-1-git-send-email-guillaume.gourat@nexvision.fr>
	<1405936382-6544-4-git-send-email-guillaume.gourat@nexvision.fr>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1405936382-6544-4-git-send-email-guillaume.gourat@nexvision.fr>
Subject: Re: [ptxdist] [PATCH 4/6] glog: add new package
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Jul 21, 2014 at 11:53:00AM +0200, Guillaume Gourat wrote:
> From: Guillaume GOURAT <guillaume.gourat@nexvision.fr>
> 
> 
> Signed-off-by: Guillaume GOURAT <guillaume.gourat@nexvision.fr>
> ---
>  rules/glog.in   |   24 ++++++++++++++++++++++++
>  rules/glog.make |   54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 78 insertions(+)
>  create mode 100755 rules/glog.in
>  create mode 100755 rules/glog.make
> 
> diff --git a/rules/glog.in b/rules/glog.in
> new file mode 100755
> index 0000000..9fecc9c
> --- /dev/null
> +++ b/rules/glog.in
> @@ -0,0 +1,24 @@
> +## SECTION=system_libraries
> +
> +menuconfig GLOG
> +	tristate
> +	prompt "glog                          "
> +	select LIBC_M
> +	select LIBC_PTHREAD
> +	select GCCLIBS_GCC_S
> +	select GCCLIBS_CXX
> +	select GFLAGS if GLOG_USE_GFLAGS
> +	help
> +	  The glog library implements application-level logging. This library 
> +	  provides logging APIs based on C++-style streams and various helper 
> +	  macros.
> +	  
> +	  See https://code.google.com/p/google-glog/ for info about it.
> +
> +if GLOG
> +
> +config GLOG_USE_GFLAGS
> +	bool
> +	prompt "commandline flags processing using gflags"
> +
> +endif
> diff --git a/rules/glog.make b/rules/glog.make
> new file mode 100755
> index 0000000..522153a
> --- /dev/null
> +++ b/rules/glog.make
> @@ -0,0 +1,54 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2014 by Guillaume GOURAT <guillaume.gourat@nexvision.fr>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_GLOG) += glog
> +
> +#
> +# Paths and names
> +#
> +GLOG_VERSION	:= 0.3.3
> +GLOG_MD5 	:= a6fd2c22f8996846e34c763422717c18
> +GLOG		:= glog-$(GLOG_VERSION)
> +GLOG_SUFFIX	:= tar.gz
> +GLOG_URL	:= http://google-glog.googlecode.com/files/$(GLOG).$(GLOG_SUFFIX)
> +GLOG_SOURCE	:= $(SRCDIR)/$(GLOG).$(GLOG_SUFFIX)
> +GLOG_DIR		:= $(BUILDDIR)/$(GLOG)
> +GLOG_LICENSE	:= BSD New
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +GLOG_CONF_TOOL	:= autoconf
> +GLOG_ENV 	:= $(CROSS_ENV) LIBS='-lgcc'

what's "LIBS='-lgcc'" for?

And gflags must be disabled by force, if not selected. Add this too GLOG_ENV:

ac_cv_lib_gflags_main=$(call ptx/ifdef, PTXCONF_GLOG_USE_GFLAGS,,no)

> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/glog.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, glog)
> +	@$(call install_fixup, glog,PRIORITY,optional)
> +	@$(call install_fixup, glog,SECTION,base)
> +	@$(call install_fixup, glog,AUTHOR,"Guillaume GOURAT <guillaume.gourat@nexvision.fr>")
> +	@$(call install_fixup, glog,DESCRIPTION,missing)
> +
> +	@$(call install_lib, glog, 0, 0, 0644, libglog)
> +
> +	@$(call install_finish, glog)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 1.7.10.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de