From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1XOOna-0004CX-2c
	for ptxdist@pengutronix.de; Mon, 01 Sep 2014 12:25:22 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1XOOnU-0002gV-1P
	for ptxdist@pengutronix.de; Mon, 01 Sep 2014 12:25:16 +0200
Date: Mon, 1 Sep 2014 12:25:16 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140901102516.GC5271@pengutronix.de>
References: <1405936382-6544-1-git-send-email-guillaume.gourat@nexvision.fr>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1405936382-6544-1-git-send-email-guillaume.gourat@nexvision.fr>
Subject: Re: [ptxdist] [PATCH 1/6] libconfig: new package
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Jul 21, 2014 at 11:52:57AM +0200, Guillaume Gourat wrote:
> From: Guillaume GOURAT <guillaume.gourat@nexvision.fr>
> 

Please address the comments I made for the last version.

Michael

> Signed-off-by: Guillaume GOURAT <guillaume.gourat@nexvision.fr>
> ---
>  rules/libconfig.in   |   27 ++++++++++++++++++++++
>  rules/libconfig.make |   63 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 90 insertions(+)
>  create mode 100644 rules/libconfig.in
>  create mode 100644 rules/libconfig.make
> 
> diff --git a/rules/libconfig.in b/rules/libconfig.in
> new file mode 100644
> index 0000000..286668a
> --- /dev/null
> +++ b/rules/libconfig.in
> @@ -0,0 +1,27 @@
> +## SECTION=system_libraries
> +
> +menuconfig LIBCONFIG
> +	tristate
> +	prompt "libconfig                     "
> +	select LIBC_M
> +	select GCCLIBS_GCC_S
> +	select GCCLIBS_CXX
> +	help
> +	  Libconfig is a simple library for processing structured configuration
> +	  files. Libconfig is very compact, a fraction of the size of the expat
> +	  XML parser library. This makes it well-suited for memory-constrained
> +	  systems like handheld devices.
> +
> +          See http://www.hyperrealm.com/libconfig/ for info about it.
> +
> +if LIBCONFIG
> + 
> +config LIBCONFIG_INSTALL_LIBCONFIG_SO
> +	bool
> +	prompt "Install libconfig on the target"
> +
> +config LIBCONFIG_INSTALL_LIBCONFIGPP_SO
> +	bool
> +	prompt "Install libconfig++ on the target"
> +
> +endif
> diff --git a/rules/libconfig.make b/rules/libconfig.make
> new file mode 100644
> index 0000000..26919d3
> --- /dev/null
> +++ b/rules/libconfig.make
> @@ -0,0 +1,63 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2014 by Guillaume Gourat <guillaume.gourat@nexvision.fr> 
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_LIBCONFIG) += libconfig
> +
> +#
> +# Paths and names
> +#
> +LIBCONFIG_VERSION	:= 1.4.9
> +LIBCONFIG_MD5	:= b6ee0ce2b3ef844bad7cac2803a90634
> +LIBCONFIG		:= libconfig-$(LIBCONFIG_VERSION)
> +LIBCONFIG_SUFFIX	:= tar.gz
> +LIBCONFIG_URL		:= http://www.hyperrealm.com/libconfig/$(LIBCONFIG).$(LIBCONFIG_SUFFIX)
> +LIBCONFIG_SOURCE	:= $(SRCDIR)/$(LIBCONFIG).$(LIBCONFIG_SUFFIX)
> +LIBCONFIG_DIR		:= $(BUILDDIR)/$(LIBCONFIG)
> +LIBCONFIG_LICENSE	:= LGPL
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +LIBCONFIG_CONF_TOOL	:= autoconf
> +
> +LIBCONFIG_CONF_OPT := \
> +	$(CROSS_AUTOCONF_USR) \
> +	--disable-examples
> +	
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/libconfig.targetinstall: $(libconfig_targetinstall_deps_default)
> +	@$(call targetinfo, $@)
> +
> +	@$(call install_init, libconfig)
> +	@$(call install_fixup, libconfig,PRIORITY,optional)
> +	@$(call install_fixup, libconfig,SECTION,base)
> +	@$(call install_fixup, libconfig,AUTHOR,"Guillaume Gourat <guillaume.gourat@nexvision.fr>")
> +	@$(call install_fixup, libconfig,DESCRIPTION,missing)
> +
> +ifdef PTXCONF_LIBCONFIG_INSTALL_LIBCONFIG_SO
> +	@$(call install_lib, libconfig, 0, 0, 0644, libconfig)
> +endif
> +
> +ifdef PTXCONF_LIBCONFIG_INSTALL_LIBCONFIGPP_SO
> +	@$(call install_lib, libconfig, 0, 0, 0644, libconfig++)
> +endif
> +
> +	@$(call install_finish, libconfig)
> +
> +	@$(call touch, $@)
> +
> +# vim: syntax=make
> -- 
> 1.7.10.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de