From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1XONmr-0007yP-U4
	for ptxdist@pengutronix.de; Mon, 01 Sep 2014 11:20:33 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1XONml-0007Sf-So
	for ptxdist@pengutronix.de; Mon, 01 Sep 2014 11:20:27 +0200
Date: Mon, 1 Sep 2014 11:20:27 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140901092027.GF12397@pengutronix.de>
References: <1407134971-3887-1-git-send-email-alexander.stein@systec-electronic.com>
	<20140818075037.GB16424@pengutronix.de>
	<7124302.PM5OnXHlFd@ws-stein>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <7124302.PM5OnXHlFd@ws-stein>
Subject: Re: [ptxdist] [PATCH] dtc: Do not inhibit linemarker generation
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Aug 18, 2014 at 01:34:48PM +0200, Alexander Stein wrote:
> On Monday 18 August 2014 09:50:37, Michael Olbrich wrote:
> > On Mon, Aug 04, 2014 at 08:49:31AM +0200, Alexander Stein wrote:
> > > Without linemarkers the error messages are somehwat useless.
> > > To demonstrate I picked a random .dts file file from the arm tree in
> > > linux sources:
> > > DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> > > Error: /tmp/testprj/platform/state/vf610-twr.dts.tmp:366.1-5 syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > 
> > > If linemarkers are inserted the error message clearly states in which file
> > > which line caused the error:
> > > 
> > > DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> > > Error: /tmp/testprj/platform/build-target/linux/arch/arm/boot/dts/vf610-twr.dts:13.1-5 syntax error
> > > FATAL ERROR: Unable to parse input tree
> > 
> > I think that means that the dtc must understand these markers, right? This
> > will most likely break building device-trees for older kernels.
> 
> AFAICS this included since dtc-1.4.0.

That's v3.6 Kernel version. We cannot depend on that. However, we already
have a check for '-i' support in ptxd_make_dts_dtb(). That was introduces
in the same commit. I'd accept a patch that adds '-P' only when dtc does
not support '-i'.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de