From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] dtc: Do not inhibit linemarker generation
Date: Mon, 18 Aug 2014 09:50:37 +0200 [thread overview]
Message-ID: <20140818075037.GB16424@pengutronix.de> (raw)
In-Reply-To: <1407134971-3887-1-git-send-email-alexander.stein@systec-electronic.com>
On Mon, Aug 04, 2014 at 08:49:31AM +0200, Alexander Stein wrote:
> Without linemarkers the error messages are somehwat useless.
> To demonstrate I picked a random .dts file file from the arm tree in
> linux sources:
> DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> Error: /tmp/testprj/platform/state/vf610-twr.dts.tmp:366.1-5 syntax error
> FATAL ERROR: Unable to parse input tree
>
> If linemarkers are inserted the error message clearly states in which file
> which line caused the error:
>
> DTC ptx-testprj_arm/platform/images/vf610-twr.dtb
> Error: /tmp/testprj/platform/build-target/linux/arch/arm/boot/dts/vf610-twr.dts:13.1-5 syntax error
> FATAL ERROR: Unable to parse input tree
I think that means that the dtc must understand these markers, right? This
will most likely break building device-trees for older kernels.
Michael
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> scripts/lib/ptxd_make_dts_dtc.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/lib/ptxd_make_dts_dtc.sh b/scripts/lib/ptxd_make_dts_dtc.sh
> index d5e8c59..3ee0897 100644
> --- a/scripts/lib/ptxd_make_dts_dtc.sh
> +++ b/scripts/lib/ptxd_make_dts_dtc.sh
> @@ -41,7 +41,6 @@ ptxd_make_dts_dtb() {
> -Wp,-MD,${tmp_deps} \
> -Wp,-MT,${tmp_dts} \
> -nostdinc \
> - -P \
> -I$(dirname "${dts}") \
> -I${dts_kernel_dir}/arch/${dts_kernel_arch}/boot/dts \
> -I${dts_kernel_dir}/arch/${dts_kernel_arch}/boot/dts/include \
> --
> 1.8.5.5
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2014-08-18 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 6:49 Alexander Stein
2014-08-18 6:26 ` Alexander Stein
2014-08-18 7:50 ` Michael Olbrich [this message]
2014-08-18 11:34 ` Alexander Stein
2014-09-01 9:20 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140818075037.GB16424@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox