Re: [ptxdist] [PATCH] django: new package to provide Django 1.6.5

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Jul 31, 2014 at 11:17:02AM +0200, Uwe Kleine-König wrote:
> On Thu, Jul 31, 2014 at 11:08:32AM +0200, Michael Olbrich wrote:
> > On Thu, Jul 31, 2014 at 10:44:09AM +0200, Uwe Kleine-König wrote:
> > > On Thu, Jul 31, 2014 at 10:14:14AM +0200, Michael Olbrich wrote:
> > > > On Wed, Jul 30, 2014 at 08:12:35PM +0200, Uwe Kleine-König wrote:
> > > > > +	# everything but locales
> > > > > +	find "$(DJANGO_PKGDIR)" -type d -name locale -prune -o -type f -printf '/%P\n' | while read fn; do \
> > > > > +		$(call install_copy, django, 0, 0, 0644, -, $$fn); \
> > > > > +	done
> > > > 
> > > > I dislike just dumping everything in the package, e.g. the egg-info is not
> > > > needed. Install /usr/bin/django-admin.py explicitly and then use:
> > > > 
> > > > 	@cd /usr/lib/python$(PYTHON_MAJORMINOR)/site-packages/django/ && find ...
> > > > 
> > > > This way it breaks in case something went wrong and the directory is
> > > > missing.
> > > I didn't do that because your approach also breaks when the path for
> > > such packages changes. AFAIK this is the case for Python 3.
> > > But I don't care much and can use your approach.
> > > 
> > > > > +	# locales
> > > > > +	find "$(DJANGO_PKGDIR)" -type d -name locale -printf '/%P\n' | while read localedir; do \
> > > > > +		for locale in $(DJANGO_LOCALES-y); do \
> > > > > +			find "$(DJANGO_PKGDIR)$$localedir/$$locale" -type f -printf "$$localedir/$$locale/%P\n" | while read fn; do \
> > > > 
> > > > Same here with 'cd' and I think the django.po files are not needed, just
> > > > the Python stuff and the compiled django.mo
> > > 
> > > 	.../Django-1.6.5$ find django -type d -name locale  | wc -l
> > > 	14
> > > 
> > > should I really list all these explicitly?
> > 
> > What I meant is:
> > 
> > 	cd "$(DJANGO_PKGDIR)" && find ...
> > 		for locale in $(DJANGO_LOCALES-y); do
> > 			cd "$(DJANGO_PKGDIR)$$localedir/$$locale" && find ...
> So you consider it an error if I want locale "sv" and this only exists
> for django, but there is a contrib module that lacks "sv" l10n?

Yes, it's an error on django... :-)

All jokes aside, if we don't do it like this, then a typo or some change in
a new version can mean that nothing is installed.
We've had that in the past with other packages. That's why I hate
installing with find.

Are any important locales affected? I'd say, be strict for now, and when it
becomes relevant, we can introduce an option for 'incomplete' locales.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de