Re: [ptxdist] [PATCH] libconfig: new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

as Uwe noted, all your patches are broken, please resent.

On Sat, Jul 19, 2014 at 10:47:01PM +0200, Guillaume GOURAT wrote:
>     libconfig: new package
>     
>     Signed-off-by: Guillaume Gourat <guillaume.gourat@nexvision.fr>
> 
> diff --git a/rules/libconfig.in b/rules/libconfig.in
> new file mode 100644
> index 0000000..286668a
> --- /dev/null
> +++ b/rules/libconfig.in
> @@ -0,0 +1,27 @@
> +## SECTION=system_libraries
> +
> +menuconfig LIBCONFIG
> +	tristate
> +	prompt "libconfig                     "
> +	select LIBC_M
> +	select GCCLIBS_GCC_S
> +	select GCCLIBS_CXX
> +	help
> +	  Libconfig is a simple library for processing structured
> configuration
> +	  files. Libconfig is very compact, a fraction of the size of the
> expat
> +	  XML parser library. This makes it well-suited for
> memory-constrained
> +	  systems like handheld devices.
> +
> +          See http://www.hyperrealm.com/libconfig/ for info about it.
> +
> +if LIBCONFIG
> + 
> +config LIBCONFIG_INSTALL_LIBCONFIG_SO
> +	bool
> +	prompt "Install libconfig on the target"
> +
> +config LIBCONFIG_INSTALL_LIBCONFIGPP_SO
> +	bool
> +	prompt "Install libconfig++ on the target"
> +
> +endif

I'm just speculating but I would expect that libconfig++ requires
libconfig. If that is the case, always install libconfig and just add one
option for libconfig++. Make sure that the dependencies are correct, I
expect GCCLIBS_CXX is only needed for libconfig++. 

Or just install both libs unconditionally.

Michael

> diff --git a/rules/libconfig.make b/rules/libconfig.make
> new file mode 100644
> index 0000000..26919d3
> --- /dev/null
> +++ b/rules/libconfig.make
> @@ -0,0 +1,63 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2014 by Guillaume Gourat <guillaume.gourat@nexvision.fr> 
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_LIBCONFIG) += libconfig
> +
> +#
> +# Paths and names
> +#
> +LIBCONFIG_VERSION	:= 1.4.9
> +LIBCONFIG_MD5	:= b6ee0ce2b3ef844bad7cac2803a90634
> +LIBCONFIG		:= libconfig-$(LIBCONFIG_VERSION)
> +LIBCONFIG_SUFFIX	:= tar.gz
> +LIBCONFIG_URL		:=
> http://www.hyperrealm.com/libconfig/$(LIBCONFIG).$(LIBCONFIG_SUFFIX)
> +LIBCONFIG_SOURCE	:= $(SRCDIR)/$(LIBCONFIG).$(LIBCONFIG_SUFFIX)
> +LIBCONFIG_DIR		:= $(BUILDDIR)/$(LIBCONFIG)
> +LIBCONFIG_LICENSE	:= LGPL
> +
> +#
> ----------------------------------------------------------------------------
> +# Prepare
> +#
> ----------------------------------------------------------------------------
> +
> +LIBCONFIG_CONF_TOOL	:= autoconf
> +
> +LIBCONFIG_CONF_OPT := \
> +	$(CROSS_AUTOCONF_USR) \
> +	--disable-examples
> +	
> +#
> ----------------------------------------------------------------------------
> +# Target-Install
> +#
> ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/libconfig.targetinstall:
> $(libconfig_targetinstall_deps_default)
> +	@$(call targetinfo, $@)
> +
> +	@$(call install_init, libconfig)
> +	@$(call install_fixup, libconfig,PRIORITY,optional)
> +	@$(call install_fixup, libconfig,SECTION,base)
> +	@$(call install_fixup, libconfig,AUTHOR,"Guillaume Gourat
> <guillaume.gourat@nexvision.fr>")
> +	@$(call install_fixup, libconfig,DESCRIPTION,missing)
> +
> +ifdef PTXCONF_LIBCONFIG_INSTALL_LIBCONFIG_SO
> +	@$(call install_lib, libconfig, 0, 0, 0644, libconfig)
> +endif
> +
> +ifdef PTXCONF_LIBCONFIG_INSTALL_LIBCONFIGPP_SO
> +	@$(call install_lib, libconfig, 0, 0, 0644, libconfig++)
> +endif
> +
> +	@$(call install_finish, libconfig)
> +
> +	@$(call touch, $@)
> +
> +# vim: syntax=make
> 
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de