From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Date: Tue, 8 Jul 2014 15:24:36 +0200
From: Alexander Aring <alex.aring@gmail.com>
Message-ID: <20140708132434.GA28466@omega>
References: <1404824365-7638-1-git-send-email-alex.aring@gmail.com>
	<1404824365-7638-2-git-send-email-alex.aring@gmail.com>
	<53BBF08A.1050802@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <53BBF08A.1050802@pengutronix.de>
Subject: Re: [ptxdist] [RFC] ptxd_make_dts_dtb: check on failure if dtc
	failed
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: ptxdist@pengutronix.de

On Tue, Jul 08, 2014 at 03:22:18PM +0200, Marc Kleine-Budde wrote:
> On 07/08/2014 02:59 PM, Alexander Aring wrote:
> > This patch adds a error handling for the dtc and call a ptxd_bailout if
> > an error occur.
> > 
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> >  scripts/lib/ptxd_make_dts_dtc.sh | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/scripts/lib/ptxd_make_dts_dtc.sh b/scripts/lib/ptxd_make_dts_dtc.sh
> > index 24c5604..6a09cae 100644
> > --- a/scripts/lib/ptxd_make_dts_dtc.sh
> > +++ b/scripts/lib/ptxd_make_dts_dtc.sh
> > @@ -59,6 +59,10 @@ ptxd_make_dts_dtb() {
> >  	-I dts -O dtb -b 0 \
> >  	-o "${dts_dtb}" "${tmp_dts}"
> >  
> > +    if [ "$?" != "0" ]; then
> > +	ptxd_bailout "Unable to generate ${dts_dtb} file."
> > +    fi
> 
> What about:
> 
>     || ptxd_bailout "Unable to generate ${dts_dtb} file."
> 

okay, yes then we could save the if. I can also add

	|| ptxd_bailout ... for cpp call.

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de