Re: [ptxdist] [RFC] ptxd_make_dts_dtb: check on failure if dtc failed

[Alexander Aring <alex.aring@gmail.com>]

On Tue, Jul 08, 2014 at 03:22:18PM +0200, Marc Kleine-Budde wrote:
> On 07/08/2014 02:59 PM, Alexander Aring wrote:
> > This patch adds a error handling for the dtc and call a ptxd_bailout if
> > an error occur.
> > 
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> >  scripts/lib/ptxd_make_dts_dtc.sh | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/scripts/lib/ptxd_make_dts_dtc.sh b/scripts/lib/ptxd_make_dts_dtc.sh
> > index 24c5604..6a09cae 100644
> > --- a/scripts/lib/ptxd_make_dts_dtc.sh
> > +++ b/scripts/lib/ptxd_make_dts_dtc.sh
> > @@ -59,6 +59,10 @@ ptxd_make_dts_dtb() {
> >  	-I dts -O dtb -b 0 \
> >  	-o "${dts_dtb}" "${tmp_dts}"
> >  
> > +    if [ "$?" != "0" ]; then
> > +	ptxd_bailout "Unable to generate ${dts_dtb} file."
> > +    fi
> 
> What about:
> 
>     || ptxd_bailout "Unable to generate ${dts_dtb} file."
> 

okay, yes then we could save the if. I can also add

	|| ptxd_bailout ... for cpp call.

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de