From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1X1vnh-0005Ut-Cs
	for ptxdist@pengutronix.de; Tue, 01 Jul 2014 13:00:37 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1X1vnh-0001Ax-BP
	for ptxdist@pengutronix.de; Tue, 01 Jul 2014 13:00:37 +0200
Date: Tue, 1 Jul 2014 13:00:37 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140701110037.GB8845@pengutronix.de>
References: <1403903740-6261-1-git-send-email-jon@ringle.org>
	<20140630090004.GG12903@pengutronix.de>
	<CAMwGMjzkFYd6vKm-nyekz7Oeuywwg=ZdvVL1Xm=Dgd7VPN+NMQ@mail.gmail.com>
	<CAMwGMjzRepFRfM1vQZ0yxRUy8uaG+D8ZnQF8VYPLHH=2x6Bh+Q@mail.gmail.com>
	<CAMwGMjwX65YfUURd9edAWwtRk8REs7-cZ9Ft75ANwVP6StchQQ@mail.gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <CAMwGMjwX65YfUURd9edAWwtRk8REs7-cZ9Ft75ANwVP6StchQQ@mail.gmail.com>
Subject: Re: [ptxdist] [PATCH] autossh: new package
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Jun 30, 2014 at 02:27:18PM -0400, Jon Ringle wrote:
> On Mon, Jun 30, 2014 at 2:22 PM, Jon Ringle <jon@ringle.org> wrote:
> >>>> +# ----------------------------------------------------------------------------
> >>>> +# Prepare
> >>>> +# ----------------------------------------------------------------------------
> >>>> +
> >>>> +AUTOSSH_CONF_TOOL    := autoconf
> >>>
> >>> Really no relevant configure options?
> >>
> >> It worked for me without specifying any configure options. However,
> >> perhaps ptxdist might care about this one:
> >>
> >>   --with-ssh=ARG       specify path to ssh executable
> >
> > However, further investigation reveals that PATH_SSH (the #define that
> > gets created based on --with-ssh configure option) does not get used
> > at all in the source code:
> >
> > $ grep -r PATH_SSH .
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:#define PATH_SSH "/usr/bin/ssh"
> > ./config.status:${ac_dA}PATH_SSH${ac_dB}PATH_SSH${ac_dC}"/usr/bin/ssh"${ac_dD}
> > ./config.status:${ac_uA}PATH_SSH${ac_uB}PATH_SSH${ac_uC}"/usr/bin/ssh"${ac_uD}
> > ./configure:#define PATH_SSH "$ac_cv_path_ssh"
> > ./configure.ac:         PATH_SSH, "$ac_cv_path_ssh",
> > ./config.h:#define PATH_SSH "/usr/bin/ssh"
> > ./config.h.in:#undef PATH_SSH
> >
> > Jon
> 
> Oh... I see now. Makefile.in uses it:
> $ grep -r path_ssh Makefile.in
> SSH=            @path_ssh@

Yes, but --with-ssh= is broken and doesn't have an effect for me.. :-/ I've
added an environment with ac_cv_path_ssh=. That seems to work.
I've amended the patch and pushed it.


Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de