mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] autossh: new package
Date: Tue, 1 Jul 2014 13:00:37 +0200	[thread overview]
Message-ID: <20140701110037.GB8845@pengutronix.de> (raw)
In-Reply-To: <CAMwGMjwX65YfUURd9edAWwtRk8REs7-cZ9Ft75ANwVP6StchQQ@mail.gmail.com>

On Mon, Jun 30, 2014 at 02:27:18PM -0400, Jon Ringle wrote:
> On Mon, Jun 30, 2014 at 2:22 PM, Jon Ringle <jon@ringle.org> wrote:
> >>>> +# ----------------------------------------------------------------------------
> >>>> +# Prepare
> >>>> +# ----------------------------------------------------------------------------
> >>>> +
> >>>> +AUTOSSH_CONF_TOOL    := autoconf
> >>>
> >>> Really no relevant configure options?
> >>
> >> It worked for me without specifying any configure options. However,
> >> perhaps ptxdist might care about this one:
> >>
> >>   --with-ssh=ARG       specify path to ssh executable
> >
> > However, further investigation reveals that PATH_SSH (the #define that
> > gets created based on --with-ssh configure option) does not get used
> > at all in the source code:
> >
> > $ grep -r PATH_SSH .
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:| #define PATH_SSH "/usr/bin/ssh"
> > ./config.log:#define PATH_SSH "/usr/bin/ssh"
> > ./config.status:${ac_dA}PATH_SSH${ac_dB}PATH_SSH${ac_dC}"/usr/bin/ssh"${ac_dD}
> > ./config.status:${ac_uA}PATH_SSH${ac_uB}PATH_SSH${ac_uC}"/usr/bin/ssh"${ac_uD}
> > ./configure:#define PATH_SSH "$ac_cv_path_ssh"
> > ./configure.ac:         PATH_SSH, "$ac_cv_path_ssh",
> > ./config.h:#define PATH_SSH "/usr/bin/ssh"
> > ./config.h.in:#undef PATH_SSH
> >
> > Jon
> 
> Oh... I see now. Makefile.in uses it:
> $ grep -r path_ssh Makefile.in
> SSH=            @path_ssh@

Yes, but --with-ssh= is broken and doesn't have an effect for me.. :-/ I've
added an environment with ac_cv_path_ssh=. That seems to work.
I've amended the patch and pushed it.


Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2014-07-01 11:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-27 21:15 jon
2014-06-30  9:00 ` Michael Olbrich
2014-06-30 18:15   ` Jon Ringle
2014-06-30 18:22     ` Jon Ringle
2014-06-30 18:27       ` Jon Ringle
2014-07-01 11:00         ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140701110037.GB8845@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox