From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1WzQc9-0008UK-7c
	for ptxdist@pengutronix.de; Tue, 24 Jun 2014 15:18:21 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1WzQc9-0003m9-5x
	for ptxdist@pengutronix.de; Tue, 24 Jun 2014 15:18:21 +0200
Date: Tue, 24 Jun 2014 15:18:21 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140624131821.GL21175@pengutronix.de>
References: <1403249588-4857-1-git-send-email-list-09_ptxdist@tqsc.de>
	<20140623134547.GJ16937@pengutronix.de> <53A97923.40306@tqsc.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <53A97923.40306@tqsc.de>
Subject: Re: [ptxdist] [PATCH] memtester: version bump 4.0.8 -> 4.3.0
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Tue, Jun 24, 2014 at 03:12:03PM +0200, Markus Niebel wrote:
> Hello,
> 
> Am 23.06.2014 15:45, schrieb Michael Olbrich:
> >On Fri, Jun 20, 2014 at 09:33:08AM +0200, Markus Niebel wrote:
> >>From: Markus Niebel <Markus.Niebel@tq-group.com>
> >>
> >
> >Thanks, applied.
> >
> >Unrelated to this patch, but I noticed that the code is compiled without
> >optimization. Do you think it makes sense to add something like this to the
> >prepare stage:
> >
> >	@echo "CFLAGS = -O2 -g"               >> $(MEMTESTER_DIR)/Makefile
> 
> maybe changing in:
> 
> @echo "$(CROSS_CC) -O2 -DPOSIX -D_POSIX_C_SOURCE=200809L
> -D_FILE_OFFSET_BITS=64 -DTEST_NARROW_WRITES -c" >
> $(MEMTESTER_DIR)/conf-cc
> @echo "$(CROSS_CC) -s" > $(MEMTESTER_DIR)/conf-ld
> 
> and using package's own build system would be even better?

Indeed. Or maybe:
@sed -i 's/^cc\>/$(CROSS_CC)/' $(MEMTESTER_DIR)/conf-cc $(MEMTESTER_DIR)/conf-ld

So we don't have to duplicate the arguments.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de