Re: [ptxdist] [PATCH] memtester: version bump 4.0.8 -> 4.3.0

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Jun 24, 2014 at 03:12:03PM +0200, Markus Niebel wrote:
> Hello,
> 
> Am 23.06.2014 15:45, schrieb Michael Olbrich:
> >On Fri, Jun 20, 2014 at 09:33:08AM +0200, Markus Niebel wrote:
> >>From: Markus Niebel <Markus.Niebel@tq-group.com>
> >>
> >
> >Thanks, applied.
> >
> >Unrelated to this patch, but I noticed that the code is compiled without
> >optimization. Do you think it makes sense to add something like this to the
> >prepare stage:
> >
> >	@echo "CFLAGS = -O2 -g"               >> $(MEMTESTER_DIR)/Makefile
> 
> maybe changing in:
> 
> @echo "$(CROSS_CC) -O2 -DPOSIX -D_POSIX_C_SOURCE=200809L
> -D_FILE_OFFSET_BITS=64 -DTEST_NARROW_WRITES -c" >
> $(MEMTESTER_DIR)/conf-cc
> @echo "$(CROSS_CC) -s" > $(MEMTESTER_DIR)/conf-ld
> 
> and using package's own build system would be even better?

Indeed. Or maybe:
@sed -i 's/^cc\>/$(CROSS_CC)/' $(MEMTESTER_DIR)/conf-cc $(MEMTESTER_DIR)/conf-ld

So we don't have to duplicate the arguments.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de