Re: [ptxdist] [PATCH 1/3] host-libftdi1: add new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sun, Jun 22, 2014 at 09:41:07AM +0200, Michael Grzeschik wrote:
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
>  rules/host-libftdi1.in   |  7 +++++++
>  rules/host-libftdi1.make | 27 +++++++++++++++++++++++++++
>  2 files changed, 34 insertions(+)
>  create mode 100644 rules/host-libftdi1.in
>  create mode 100644 rules/host-libftdi1.make
> 
> diff --git a/rules/host-libftdi1.in b/rules/host-libftdi1.in
> new file mode 100644
> index 0000000..ee800c8
> --- /dev/null
> +++ b/rules/host-libftdi1.in
> @@ -0,0 +1,7 @@
> +## SECTION=hosttools_noprompt

> +## SECTION=hosttools_platform

Don't add this unless it's used in the platform

> +
> +config HOST_LIBFTDI1
> +	tristate
> +	select HOST_CMAKE
> +	default ALLYES
> diff --git a/rules/host-libftdi1.make b/rules/host-libftdi1.make
> new file mode 100644
> index 0000000..7ae6f8a
> --- /dev/null
> +++ b/rules/host-libftdi1.make
> @@ -0,0 +1,27 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2014 by Michael Grzeschik <mgr@pengutronix.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +HOST_PACKAGES-$(PTXCONF_HOST_LIBFTDI1) += host-libftdi1
> +

# ----------------------------------------------------------------------------
# Prepare
# ----------------------------------------------------------------------------

> +HOST_LIBFTDI1_CONF_TOOL	:= cmake
> +HOST_LIBFTDI1_CONF_OPT	:= \
> +	$(HOST_CMAKE_USR) \
> +	-DCMAKE_SKIP_RPATH=ON \

I don't think that this is correct for host packages.

> +	-DDOCUMENTATION=OFF \
> +	-DPYTHON_BINDINGS=OFF \
> +	-DEXAMPLES=$(call ptx/ifdef,PTXCONF_LIBFTDI1_EXAMPLES,ON,OFF) \
> +	-DFTDIPP=$(call ptx/ifdef,PTXCONF_LIBFTDI1_CPP_WRAPPER,ON,OFF) \
> +	-DFTDI_EEPROM=$(call ptx/ifdef,PTXCONF_LIBFTDI1_FTDI_EEPROM,ON,OFF)

Don't use the options for the target package. Choose sane defaults.

Michael

> +
> +
> +# vim: syntax=make
> -- 
> 2.0.0
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de