mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 3/4] kbd: rework and version bump 1.15.2 -> 2.0.1
Date: Sun, 15 Jun 2014 22:51:51 +0200	[thread overview]
Message-ID: <20140615205145.GA16097@omega> (raw)
In-Reply-To: <1402862806-7297-3-git-send-email-alex.aring@gmail.com>

Hi,

sorry my testing failed here.

On Sun, Jun 15, 2014 at 10:06:45PM +0200, Alexander Aring wrote:
...

>  # ----------------------------------------------------------------------------
>  # Target-Install
>  # ----------------------------------------------------------------------------
> @@ -55,32 +80,51 @@ $(STATEDIR)/kbd.targetinstall:
>  	@$(call install_fixup, kbd,AUTHOR,"Luotao Fu <l.fu@pengutronix.de>")
>  	@$(call install_fixup, kbd,DESCRIPTION,missing)
>  
> -ifdef PTXCONF_KBD_DUMPKEYS
> -	@$(call install_copy, kbd, 0, 0, 0755, -, /usr/bin/dumpkeys)
> -endif
> +	@$(foreach tool,$(KBD_TOOLS-y), \
> +		$(call install_copy, kbd, 0, 0, 0755, -, \
> +		/usr/bin/$(tool));)
>  
> -ifdef PTXCONF_KBD_LOADKEYS
> -	@$(call install_copy, kbd, 0, 0, 0755, -, /usr/bin/loadkeys)
> +ifdef PTXCONF_KBD_PSFXTABLE
> +	@$(call install_link, kbd, psfxtable, /usr/bin/psfaddtable)
> +	@$(call install_link, kbd, psfxtable, /usr/bin/psfgettable)
> +	@$(call install_link, kbd, psfxtable, /usr/bin/psfstriptable)
>  endif
>  
> -ifdef PTXCONF_KBD_GETKEYCODES
> -	@$(call install_copy, kbd, 0, 0, 0755, -, /usr/bin/getkeycodes)
> -endif
>  
> -ifdef PTXCONF_KBD_SETKEYCODES
> -	@$(call install_copy, kbd, 0, 0, 0755, -, /usr/bin/setkeycodes)
> +ifdef PTXCONF_KBD_CONSOLEFONTS
> +	@cd $(KBD_PKGDIR)/usr/share/consolefonts; \
> +	find . -type f | while read file; do \
> +                $(call install_copy, kbd, 0, 0, 0644, -, \
> +                        /usr/share/consolefonts/$$file); \
> +        done
>  endif
>  
> -ifdef PTXCONF_KBD_SHOWKEY
> -	@$(call install_copy, kbd, 0, 0, 0755, -, /usr/bin/showkey)
> +ifdef PTXCONF_KBD_CONSOLETRANS
> +	@cd $(KBD_PKGDIR)/usr/share/consoletrans; \
> +	find . -type f | while read file; do \
> +                $(call install_copy, kbd, 0, 0, 0644, -, \
> +                        /usr/share/consoletrans/$$file); \
> +        done
>  endif
>  
> -ifdef PTXCONF_KBD_CHVT
> -	@$(call install_copy, kbd, 0, 0, 0755, -, /usr/bin/chvt)
> +ifdef PTXCONF_KBD_KEYMAPS
> +	@cd $(KBD_PKGDIR)/usr/share/keymaps; \
> +	find . -type f | while read file; do \
> +                $(call install_copy, kbd, 0, 0, 0644, -, \
> +                        /usr/share/keymaps/$$file); \
> +        done
> +
> +	@$(call install_link, kbd, mac, ppc)

This should be @$(call install_link, kbd, mac, /usr/share/keymaps/ppc)
>  endif
>  
> -ifdef PTXCONF_KBD_DEALLOCVT
> -	@$(call install_copy, kbd, 0, 0, 0755, -, /usr/bin/deallocvt)
> +ifdef PTXCONF_KBD_UNIMAPS
> +	@cd $(KBD_PKGDIR)/usr/share/unimaps; \
> +	find . -type f | while read file; do \
> +                $(call install_copy, kbd, 0, 0, 0644, -, \
> +                        /usr/share/unimaps/$$file); \
> +        done
> +
> +	@$(call install_link, kbd, mac, ppc)

This should be removed, copy&paste failure.

Sorry, I will send a v2 if the rest seems to be okay.

- Alex

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2014-06-15 20:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-15 20:06 [ptxdist] [PATCH 1/4] libusb: fix libusbx to libusb prompt Alexander Aring
2014-06-15 20:06 ` [ptxdist] [PATCH 2/4] protobuf: version bump 2.4.1 -> 2.5.0 Alexander Aring
2014-06-16 19:01   ` Michael Olbrich
2014-06-15 20:06 ` [ptxdist] [PATCH 3/4] kbd: rework and version bump 1.15.2 -> 2.0.1 Alexander Aring
2014-06-15 20:51   ` Alexander Aring [this message]
2014-06-16 18:22   ` Michael Olbrich
2014-06-16 19:03     ` Alexander Aring
2014-06-16 19:15       ` Michael Olbrich
2014-06-15 20:06 ` [ptxdist] [PATCH 4/4] cmatrix: add new package Alexander Aring
2014-06-16 18:47   ` Michael Olbrich
2014-06-16 19:06     ` Alexander Aring
2014-06-16 19:00 ` [ptxdist] [PATCH 1/4] libusb: fix libusbx to libusb prompt Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140615205145.GA16097@omega \
    --to=alex.aring@gmail.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox