From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1Wuc2l-0005Gy-VS for ptxdist@pengutronix.de; Wed, 11 Jun 2014 08:29:55 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1Wuc2l-0002HG-U5 for ptxdist@pengutronix.de; Wed, 11 Jun 2014 08:29:55 +0200 Date: Wed, 11 Jun 2014 08:29:55 +0200 From: Michael Olbrich Message-ID: <20140611062955.GM4904@pengutronix.de> References: <1400145009-4662-1-git-send-email-t.gamez@phytec.de> <20140516064516.GA25124@omega> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140516064516.GA25124@omega> Subject: Re: [ptxdist] [PATCH v2 1/2] dtc: Seperate path and filename of dts Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de Hi, I've rewritten the patch taking these issues into account. I'll merge it after the release. On Fri, May 16, 2014 at 08:45:19AM +0200, Alexander Aring wrote: > I detected a new issue with this patch. > > > First: > > Before it was possible to have something like: > > PTXCONF_DTC_OFTREE_DTS="/bar/foo/foobar.dts /foo/bar/barfoo.dts" > > These files have a different basename. With your patch the basename must > be one unique basename. I mean okay, we could drop this and force the > ptxdist users that all dts files need to be under one location. > > or > > we make a for-each to search all directories of DTS_PATH, then we could > configure something like that: > > DTC_OFTREE_DTS_PATHS="/bar/foo /foo/bar" > DTC_OFTREE_DTS="foobar.dts barfoo.dts" I've used ':' as a separater for the path. > Second: > > We should write some migrate sed pattern for > "scripts/migrate/migrate_ptx". I think this becomes a little bit > complicated, if you like I can try to help you there. ;) Doing this correctly in sed seems rather complex: - don't do anything if DTC_OFTREE_DTS_PATHS is already set - move all directories to DTC_OFTREE_DTS_PATHS - make them unique Instead I've done this backwards compatible: Don't add DTC_OFTREE_DTS_PATHS if the filename starts with '/'. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de