Re: [ptxdist] [PATCH v2 1/2] dtc: Seperate path and filename of dts

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

I've rewritten the patch taking these issues into account.
I'll merge it after the release.

On Fri, May 16, 2014 at 08:45:19AM +0200, Alexander Aring wrote:
> I detected a new issue with this patch.
> 
> 
> First:
> 
> Before it was possible to have something like:
> 
> PTXCONF_DTC_OFTREE_DTS="/bar/foo/foobar.dts /foo/bar/barfoo.dts"
> 
> These files have a different basename. With your patch the basename must
> be one unique basename. I mean okay, we could drop this and force the
> ptxdist users that all dts files need to be under one location.
> 
> or
> 
> we make a for-each to search all directories of DTS_PATH, then we could
> configure something like that:
> 
> DTC_OFTREE_DTS_PATHS="/bar/foo /foo/bar"
> DTC_OFTREE_DTS="foobar.dts barfoo.dts"

I've used ':' as a separater for the path.

> Second:
> 
> We should write some migrate sed pattern for
> "scripts/migrate/migrate_ptx". I think this becomes a little bit
> complicated, if you like I can try to help you there. ;)

Doing this correctly in sed seems rather complex:
- don't do anything if DTC_OFTREE_DTS_PATHS is already set
- move all directories to DTC_OFTREE_DTS_PATHS
- make them unique

Instead I've done this backwards compatible: Don't add DTC_OFTREE_DTS_PATHS
if the filename starts with '/'.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de