mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] classpath: Fix JAVA autoconf variable
Date: Mon, 2 Jun 2014 09:54:40 +0200	[thread overview]
Message-ID: <20140602075440.GJ26228@pengutronix.de> (raw)
In-Reply-To: <CABDcavbZnV5haSotBCOkXRRTzMFXQWaMpZt+k0ufXPfy+yeSUA@mail.gmail.com>

Same tabs/spaces issue here.

On Mon, May 19, 2014 at 12:30:14PM +0200, Guillermo Rodriguez Garcia wrote:
> JAVA must point to the java binary on the target, not on the host
> This is used in the shell scripts in tools/*, which are installed on the target
> 
> Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
> ---
>  rules/classpath.make |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/rules/classpath.make b/rules/classpath.make
> index ad3b7e7..c5aa02f 100644
> --- a/rules/classpath.make
> +++ b/rules/classpath.make
> @@ -32,10 +32,14 @@ CLASSPATH_PATH := PATH=$(CROSS_PATH)
>  CLASSPATH_ENV := \
>   $(CROSS_ENV) \
>   JAVAC=$(PTXCONF_SETUP_JAVA_SDK)/bin/javac \
> - JAVA=$(PTXCONF_SETUP_JAVA_SDK)/bin/java \
> + JAVA=jamvm \

So '$(JAVA)' is never used at build-time, There is only a check for its
existence, right?

>   CLASSPATH=$(PTXCONF_SETUP_JAVA_SDK)/jre/lib \
> + ac_cv_prog_java_works=yes \

... and we overwrite that here.

Looks good I think. Please resend with correct whitespaces.

Michael

>   ac_cv_prog_javac_is_gcj=no
> 
> +# JAVA must point to the java binary on the target, not on the host
> +# This is used by the scripts in tools/*
> +
>  #
>  # autoconf
>  #
> -- 
> 1.7.0.4
> 
> -- 
> Guillermo Rodriguez Garcia
> guille.rodriguez@gmail.com
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

      reply	other threads:[~2014-06-02  7:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-19 10:30 Guillermo Rodriguez Garcia
2014-06-02  7:54 ` Michael Olbrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140602075440.GJ26228@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox