[ptxdist] [PATCH] configure: consolidate compiler checks

[ptxdist] [PATCH] configure: consolidate compiler checks

[Andreas Bießmann]

Remove redundant check for GCC and move compiler checks to the beginning.
Before the AC_HEADERS_STDC checked for compilers implicitly and later on we
checked again explicitly for them.

Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
---
 configure.ac | 26 +++++++++++---------------
 1 file changed, 11 insertions(+), 15 deletions(-)

diff --git a/configure.ac b/configure.ac
index 390fcaf..c33cbb4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -23,6 +23,17 @@ else
 	AC_MSG_ERROR([install the ptxdist-patches archive into the same directory as ptxdist.])
 fi
 
+dnl
+dnl Check for C and C++ compilers
+dnl
+AC_PROG_CC
+if test -z "$CC"; then
+	AC_MSG_ERROR([gcc could not be found, please install])
+fi
+AC_PROG_CXX
+if test -z "$CXX"; then
+	AC_MSG_ERROR([g++ could not be found, please install])
+fi
 
 dnl
 dnl Check header files, mostly for lxdialog & kconfig
@@ -160,18 +171,6 @@ GNU_TOOL(xargs, findutils)
 dnl Check for egrep
 AC_PROG_EGREP
 
-dnl Check for gcc
-AC_PROG_CC
-if test -z "$CC"; then
-	AC_MSG_ERROR([gcc could not be found, please install])
-fi
-
-dnl Check for g++
-AC_PROG_CXX
-if test -z "$CXX"; then
-	AC_MSG_ERROR([g++ could not be found, please install])
-fi
-
 dnl Check for awk
 AC_PROG_AWK
 AC_PATH_PROGS(AWK, ${AWK},)
@@ -285,9 +284,6 @@ if test -z "$MSGFMT"; then
 	AC_MSG_ERROR([gettext could not be found, please install])
 fi
 
-dnl Check for gcc
-AC_PATH_PROGS(GCC, gcc,, $PATH)
-
 dnl
 dnl Checks for Python, needed for ipkg-utils
 dnl
-- 
1.9.2


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] configure: consolidate compiler checks

[Michael Olbrich]

On Tue, Apr 22, 2014 at 12:09:26AM +0200, Andreas Bießmann wrote:
> Remove redundant check for GCC and move compiler checks to the beginning.
> Before the AC_HEADERS_STDC checked for compilers implicitly and later on we
> checked again explicitly for them.
> 
> Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
> ---
>  configure.ac | 26 +++++++++++---------------
>  1 file changed, 11 insertions(+), 15 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 390fcaf..c33cbb4 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -23,6 +23,17 @@ else
>  	AC_MSG_ERROR([install the ptxdist-patches archive into the same directory as ptxdist.])
>  fi
>  
> +dnl
> +dnl Check for C and C++ compilers
> +dnl
> +AC_PROG_CC
> +if test -z "$CC"; then
> +	AC_MSG_ERROR([gcc could not be found, please install])
> +fi
> +AC_PROG_CXX
> +if test -z "$CXX"; then
> +	AC_MSG_ERROR([g++ could not be found, please install])
> +fi

While you're at this: The extra messages are not necessary.
configure fails before that with:

configure: error: no acceptable C compiler found in $PATH

Michael

>  
>  dnl
>  dnl Check header files, mostly for lxdialog & kconfig
> @@ -160,18 +171,6 @@ GNU_TOOL(xargs, findutils)
>  dnl Check for egrep
>  AC_PROG_EGREP
>  
> -dnl Check for gcc
> -AC_PROG_CC
> -if test -z "$CC"; then
> -	AC_MSG_ERROR([gcc could not be found, please install])
> -fi
> -
> -dnl Check for g++
> -AC_PROG_CXX
> -if test -z "$CXX"; then
> -	AC_MSG_ERROR([g++ could not be found, please install])
> -fi
> -
>  dnl Check for awk
>  AC_PROG_AWK
>  AC_PATH_PROGS(AWK, ${AWK},)
> @@ -285,9 +284,6 @@ if test -z "$MSGFMT"; then
>  	AC_MSG_ERROR([gettext could not be found, please install])
>  fi
>  
> -dnl Check for gcc
> -AC_PATH_PROGS(GCC, gcc,, $PATH)
> -
>  dnl
>  dnl Checks for Python, needed for ipkg-utils
>  dnl
> -- 
> 1.9.2
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

[ptxdist] [PATCH v2] configure: consolidate compiler checks

[Andreas Bießmann]

Remove redundant check for GCC and move compiler checks to the beginning.
Before the AC_HEADERS_STDC checked for compilers implicitly and later on we
checked again explicitly for them.

Signed-off-by: Andreas Bießmann <andreas@biessmann.de>
---

Changes in v2:
* remove redundant error messages for CC and CXX

 configure.ac |   20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/configure.ac b/configure.ac
index 390fcaf..22c8df0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -23,6 +23,11 @@ else
 	AC_MSG_ERROR([install the ptxdist-patches archive into the same directory as ptxdist.])
 fi
 
+dnl
+dnl Check for C and C++ compilers
+dnl
+AC_PROG_CC
+AC_PROG_CXX
 
 dnl
 dnl Check header files, mostly for lxdialog & kconfig
@@ -160,18 +165,6 @@ GNU_TOOL(xargs, findutils)
 dnl Check for egrep
 AC_PROG_EGREP
 
-dnl Check for gcc
-AC_PROG_CC
-if test -z "$CC"; then
-	AC_MSG_ERROR([gcc could not be found, please install])
-fi
-
-dnl Check for g++
-AC_PROG_CXX
-if test -z "$CXX"; then
-	AC_MSG_ERROR([g++ could not be found, please install])
-fi
-
 dnl Check for awk
 AC_PROG_AWK
 AC_PATH_PROGS(AWK, ${AWK},)
@@ -285,9 +278,6 @@ if test -z "$MSGFMT"; then
 	AC_MSG_ERROR([gettext could not be found, please install])
 fi
 
-dnl Check for gcc
-AC_PATH_PROGS(GCC, gcc,, $PATH)
-
 dnl
 dnl Checks for Python, needed for ipkg-utils
 dnl
-- 
1.7.10.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH v2] configure: consolidate compiler checks

[Michael Olbrich]

On Wed, Apr 23, 2014 at 11:15:08AM +0200, Andreas Bießmann wrote:
> Remove redundant check for GCC and move compiler checks to the beginning.
> Before the AC_HEADERS_STDC checked for compilers implicitly and later on we
> checked again explicitly for them.
> 
> Signed-off-by: Andreas Bießmann <andreas@biessmann.de>

Thanks, applied.

Michael

> ---
> 
> Changes in v2:
> * remove redundant error messages for CC and CXX
> 
>  configure.ac |   20 +++++---------------
>  1 file changed, 5 insertions(+), 15 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 390fcaf..22c8df0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -23,6 +23,11 @@ else
>  	AC_MSG_ERROR([install the ptxdist-patches archive into the same directory as ptxdist.])
>  fi
>  
> +dnl
> +dnl Check for C and C++ compilers
> +dnl
> +AC_PROG_CC
> +AC_PROG_CXX
>  
>  dnl
>  dnl Check header files, mostly for lxdialog & kconfig
> @@ -160,18 +165,6 @@ GNU_TOOL(xargs, findutils)
>  dnl Check for egrep
>  AC_PROG_EGREP
>  
> -dnl Check for gcc
> -AC_PROG_CC
> -if test -z "$CC"; then
> -	AC_MSG_ERROR([gcc could not be found, please install])
> -fi
> -
> -dnl Check for g++
> -AC_PROG_CXX
> -if test -z "$CXX"; then
> -	AC_MSG_ERROR([g++ could not be found, please install])
> -fi
> -
>  dnl Check for awk
>  AC_PROG_AWK
>  AC_PATH_PROGS(AWK, ${AWK},)
> @@ -285,9 +278,6 @@ if test -z "$MSGFMT"; then
>  	AC_MSG_ERROR([gettext could not be found, please install])
>  fi
>  
> -dnl Check for gcc
> -AC_PATH_PROGS(GCC, gcc,, $PATH)
> -
>  dnl
>  dnl Checks for Python, needed for ipkg-utils
>  dnl
> -- 
> 1.7.10.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de