From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1WcrDx-0001dh-HN
	for ptxdist@pengutronix.de; Wed, 23 Apr 2014 09:04:05 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1WcrDy-0002Zc-ON
	for ptxdist@pengutronix.de; Wed, 23 Apr 2014 09:04:06 +0200
Date: Wed, 23 Apr 2014 09:04:06 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140423070406.GD3804@pengutronix.de>
References: <1398200023-10099-1-git-send-email-bernhard@bwalle.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1398200023-10099-1-git-send-email-bernhard@bwalle.de>
Subject: Re: [ptxdist] [PATCH] perl: Make it possible to enable thread
	support
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Tue, Apr 22, 2014 at 10:53:43PM +0200, Bernhard Walle wrote:
> Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
> ---
>  rules/perl.in   | 12 ++++++++++--
>  rules/perl.make |  4 +++-
>  2 files changed, 13 insertions(+), 3 deletions(-)
> 
> diff --git a/rules/perl.in b/rules/perl.in
> index 6a226de..4823a3e 100644
> --- a/rules/perl.in
> +++ b/rules/perl.in
> @@ -1,17 +1,25 @@
>  ## SECTION=scripting_languages
>  
> -config PERL
> +menuconfig PERL
>  	tristate
> -	prompt "perl"
> +	prompt "perl                          "
>  	select LIBC_DL
>  	select LIBC_M
>  	select LIBC_CRYPT
>  	select GCCLIBS_GCC_S
> +	select LIBC_PTHREAD	if PERL_THREADS
>  	help
>  	  Larry Wall's Practical Extraction and Report Language
>  	  An interpreted scripting language, known among some as
>  	  "Unix's Swiss Army Chainsaw".
>  
> +if PERL
> +
> +config PERL_THREADS
> +	bool "Enable threads"
> +
> +endif

As I said, I'm not sure if this should be optional.

> +
>  menu "perl Extra Modules            "
>  source "generated/perl.in"
>  endmenu
> diff --git a/rules/perl.make b/rules/perl.make
> index 86a0ff7..fe09089 100644
> --- a/rules/perl.make
> +++ b/rules/perl.make
> @@ -65,7 +65,9 @@ PERL_CONF_OPT	:= \
>  	--prefix=/usr \
>  	--host=$(PTXCONF_GNU_TARGET) \
>  	--target=$(PTXCONF_GNU_TARGET) \
> -	-Dld=$(CROSS_CC)
> +	-Dld=$(CROSS_CC) \
> +	$(call ptx/ifdef, PTXCONF_PERL_THREADS, -Dusethreads, ) \
> +	$(call ptx/ifdef, PTXCONF_PERL_THREADS, -A ldflags=-pthread, )

You got a link error here because -lpthread is missing, right?

Michael

>  
>  PERL_MAKE_PAR	:= NO
>  
> -- 
> 1.9.1
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de