From: Alexander Aring <alex.aring@gmail.com>
To: "Andreas Bießmann" <andreas@biessmann.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v4 2/4] configure.ac: add check for python 2.x version
Date: Sun, 20 Apr 2014 18:55:35 +0200 [thread overview]
Message-ID: <20140420165534.GA18324@omega> (raw)
In-Reply-To: <5353EAA2.4080207@biessmann.de>
On Sun, Apr 20, 2014 at 05:41:22PM +0200, Andreas Bießmann wrote:
> Hi Alexander,
>
> On 20.04.14 15:26, Alexander Aring wrote:
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> > configure.ac | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 2a97944..3d1036d 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -304,6 +304,18 @@ AC_ARG_WITH(python, AS_HELP_STRING([--with-python],[name of the python executabl
> > AC_PATH_PROGS(PYTHON, python2.7 python2.6 python)
> > AC_SUBST(PYTHON)
> > ])
> > +
> > +dnl
> > +dnl Check for Python 2.x
> > +dnl
> > +AC_MSG_CHECKING([check for Python version])
>
> I would remove the 'check' in this message:
>
> ---8<---
> checking check for Python version... 2.7.6
> --->8---
>
> Usual phrase is 'checking for ...'
>
yep. Ok.
- Alex
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2014-04-20 16:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 13:26 [ptxdist] [PATCH v4 0/4] ptxdist: check python configure.ac and libusb Alexander Aring
2014-04-20 13:26 ` [ptxdist] [PATCH v4 1/4] libusb: rename libusbx to libusb Alexander Aring
2014-04-20 13:26 ` [ptxdist] [PATCH v4 2/4] configure.ac: add check for python 2.x version Alexander Aring
2014-04-20 15:41 ` Andreas Bießmann
2014-04-20 16:55 ` Alexander Aring [this message]
2014-04-20 13:26 ` [ptxdist] [PATCH v4 3/4] configure.ac: check for python2 binary as well Alexander Aring
2014-04-20 13:26 ` [ptxdist] [PATCH v4 4/4] configure.ac: use Python instead python everywhere Alexander Aring
2014-04-21 8:55 ` [ptxdist] [PATCH v4 0/4] ptxdist: check python configure.ac and libusb Michael Olbrich
2014-04-21 12:23 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140420165534.GA18324@omega \
--to=alex.aring@gmail.com \
--cc=andreas@biessmann.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox