From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1WbW37-0007qr-HB
	for ptxdist@pengutronix.de; Sat, 19 Apr 2014 16:15:21 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1WbW37-0005Q5-UF
	for ptxdist@pengutronix.de; Sat, 19 Apr 2014 16:15:21 +0200
Date: Sat, 19 Apr 2014 16:15:21 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140419141521.GA18640@pengutronix.de>
References: <1397554615-5820-1-git-send-email-alex.aring@gmail.com>
	<1397554615-5820-3-git-send-email-alex.aring@gmail.com>
	<20140417073834.GA30047@omega>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20140417073834.GA30047@omega>
Subject: Re: [ptxdist] [PATCH v3 2/4] configure.ac: add check for python 2.x
 version
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Thu, Apr 17, 2014 at 09:38:36AM +0200, Alexander Aring wrote:
> Hi,
> 
> On Tue, Apr 15, 2014 at 11:36:53AM +0200, Alexander Aring wrote:
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> >  configure.ac | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 2a97944..ce4e539 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -304,6 +304,18 @@ AC_ARG_WITH(python, AS_HELP_STRING([--with-python],[name of the python executabl
> >  	AC_PATH_PROGS(PYTHON, python2.7 python2.6 python)
> >  	AC_SUBST(PYTHON)
> >      ])
> > +
> > +dnl
> > +dnl Check for Python 2.x
> > +dnl
> > +AC_MSG_CHECKING([check for Python major version])
> > +PYTHON_MAJOR_VERSION=`$PYTHON -c "import sys; print(sys.version_info[[0]])" 2> /dev/null`
> 
> I think a $PYTHON -c "import sys; print(sys.version_info.major) is

$ python2.6 -c "import sys; print(sys.version_info.major)"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AttributeError: 'tuple' object has no attribute 'major'

> better here instead of the array access. I wait for Michaels opinion for
> the rest of the patches in this series. If all seems fine I will resend a v4.

Maybe parsing "$PYTHON --version" is a better idea?

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de