From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229])
	by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <alex.aring@gmail.com>) id 1WaguG-0003q4-Ab
	for ptxdist@pengutronix.de; Thu, 17 Apr 2014 09:38:51 +0200
Received: by mail-ee0-f41.google.com with SMTP id t10so288218eei.28
	for <ptxdist@pengutronix.de>; Thu, 17 Apr 2014 00:38:41 -0700 (PDT)
Received: from omega (p200300648D378576E2CB4EFFFE1BB546.dip0.t-ipconnect.de.
	[2003:64:8d37:8576:e2cb:4eff:fe1b:b546])
	by mx.google.com with ESMTPSA id t44sm64871638eeo.6.2014.04.17.00.38.40
	for <ptxdist@pengutronix.de>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Thu, 17 Apr 2014 00:38:41 -0700 (PDT)
Date: Thu, 17 Apr 2014 09:38:36 +0200
From: Alexander Aring <alex.aring@gmail.com>
Message-ID: <20140417073834.GA30047@omega>
References: <1397554615-5820-1-git-send-email-alex.aring@gmail.com>
	<1397554615-5820-3-git-send-email-alex.aring@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1397554615-5820-3-git-send-email-alex.aring@gmail.com>
Subject: Re: [ptxdist] [PATCH v3 2/4] configure.ac: add check for python 2.x
	version
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi,

On Tue, Apr 15, 2014 at 11:36:53AM +0200, Alexander Aring wrote:
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
>  configure.ac | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index 2a97944..ce4e539 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -304,6 +304,18 @@ AC_ARG_WITH(python, AS_HELP_STRING([--with-python],[name of the python executabl
>  	AC_PATH_PROGS(PYTHON, python2.7 python2.6 python)
>  	AC_SUBST(PYTHON)
>      ])
> +
> +dnl
> +dnl Check for Python 2.x
> +dnl
> +AC_MSG_CHECKING([check for Python major version])
> +PYTHON_MAJOR_VERSION=`$PYTHON -c "import sys; print(sys.version_info[[0]])" 2> /dev/null`

I think a $PYTHON -c "import sys; print(sys.version_info.major) is
better here instead of the array access. I wait for Michaels opinion for
the rest of the patches in this series. If all seems fine I will resend a v4.

- Alex


-- 
ptxdist mailing list
ptxdist@pengutronix.de