From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1Wafjx-0000aZ-4C
	for ptxdist@pengutronix.de; Thu, 17 Apr 2014 08:24:05 +0200
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1Wafjx-000395-27
	for ptxdist@pengutronix.de; Thu, 17 Apr 2014 08:24:05 +0200
Date: Thu, 17 Apr 2014 08:24:05 +0200
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140417062405.GA18382@pengutronix.de>
References: <1397651842-22245-1-git-send-email-jon@ringle.org>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1397651842-22245-1-git-send-email-jon@ringle.org>
Subject: Re: [ptxdist] [PATCH] image_tgz: Make label optional
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Wed, Apr 16, 2014 at 08:37:22AM -0400, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
> 
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
>  platforms/image_tgz.in    | 17 +++++++++++++++++
>  rules/post/image_tgz.make |  8 ++++++--
>  2 files changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/platforms/image_tgz.in b/platforms/image_tgz.in
> index 17b0aed..5843168 100644
> --- a/platforms/image_tgz.in
> +++ b/platforms/image_tgz.in
> @@ -6,3 +6,20 @@ config IMAGE_TGZ
>  	help
>  	  Build a tar.gz archive of the root filesystem, containing the
>  	  right owner/group and access permissions.
> +
> +if IMAGE_TGZ

With sub-options IMAGE_TGZ should become a menuconfig

> +
> +config IMAGE_TGZ_INCLUDE_LABEL
> +	bool
> +	prompt "Include label"
> +	help
> +      Create tgz image with a label
> +
> +if IMAGE_TGZ_INCLUDE_LABEL
> +config IMAGE_TGZ_LABEL
> +    string
> +    prompt "label"
> +    default "${PTXCONF_PROJECT_VENDOR}-${PTXCONF_PROJECT}${PTXCONF_PROJECT_VERSION}"

Just one option. Use the help text to clarify that an empty string means no
label.


> +
> +endif
> +endif
> diff --git a/rules/post/image_tgz.make b/rules/post/image_tgz.make
> index 019077d..f72b244 100644
> --- a/rules/post/image_tgz.make
> +++ b/rules/post/image_tgz.make
> @@ -10,12 +10,16 @@
>  
>  SEL_ROOTFS-$(PTXCONF_IMAGE_TGZ)		+= $(IMAGEDIR)/root.tgz
>  
> +ifdef PTXCONF_IMAGE_TGZ_LABEL
> +IMAGE_TGZ_LABEL="--label \"$(PTXCONF_IMAGE_TGZ_LABEL)\""

I'm pretty sure this is wrong. PTXCONF_IMAGE_TGZ_LABEL already contains
quotes.

Michael

> +endif
> +
>  ifdef PTXCONF_IMAGE_TGZ
>  $(IMAGEDIR)/root.tgz: $(STATEDIR)/image_working_dir
> -	@echo -n "Creating root.tgz from working dir with label..."
> +	@echo -n "Creating root.tgz from working dir: ${IMAGE_TGZ_LABEL} "
>  	@cd $(image/work_dir);							\
>  	(awk -F: $(DOPERMISSIONS) $(image/permissions) &&		\
> -	(	echo -n "tar --label '${PTXCONF_PROJECT_VENDOR}-${PTXCONF_PROJECT}${PTXCONF_PROJECT_VERSION}' -zcf ";	\
> +	(	echo -n "tar ${IMAGE_TGZ_LABEL} -zcf ";	\
>  		echo -n "$@ ." )					\
>  	) | $(FAKEROOT) --
>  	@echo "done."
> -- 
> 1.8.5.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de