From: Alexander Aring <alex.aring@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH v2 2/3] configure.ac: add check for python 2.x version
Date: Tue, 15 Apr 2014 11:28:37 +0200 [thread overview]
Message-ID: <20140415092835.GA20951@omega> (raw)
In-Reply-To: <20140415092442.GK5969@pengutronix.de>
On Tue, Apr 15, 2014 at 11:24:42AM +0200, Uwe Kleine-König wrote:
> On Tue, Apr 15, 2014 at 11:19:24AM +0200, Alexander Aring wrote:
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > ---
> > configure.ac | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 2a97944..efc67ba 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -304,6 +304,18 @@ AC_ARG_WITH(python, AS_HELP_STRING([--with-python],[name of the python executabl
> > AC_PATH_PROGS(PYTHON, python2.7 python2.6 python)
> > AC_SUBST(PYTHON)
> > ])
> > +
> > +dnl
> > +dnl Check for python 2.x
> I thought you wanted to do s/python/Python/ ?
>
> > +dnl
> > +AC_MSG_CHECKING([check for python major version])
> ditto
>
> > +PYTHON_MAJOR_VERSION=`$PYTHON -c "import sys; print(sys.version_info[[0]])" 2> /dev/null`
> > +case "$PYTHON_MAJOR_VERSION" in
> > +2) ;;
> > +*) AC_MSG_ERROR([we need python version 2.x but found $PYTHON_MAJOR_VERSION.x]) ;;
> ditto
>
I need another coffee..., Sorry.
- Alex
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2014-04-15 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 9:19 [ptxdist] [PATCH v2 0/3] ptxdist: check for python 2.x and rename libusbx Alexander Aring
2014-04-15 9:19 ` [ptxdist] [PATCH v2 1/3] libusb: rename libusbx to libusb Alexander Aring
2014-04-15 9:19 ` [ptxdist] [PATCH v2 2/3] configure.ac: add check for python 2.x version Alexander Aring
2014-04-15 9:24 ` Uwe Kleine-König
2014-04-15 9:28 ` Alexander Aring [this message]
2014-04-15 9:26 ` Alexander Aring
2014-04-15 9:19 ` [ptxdist] [PATCH v2 3/3] configure.ac: check for python2 binary as well Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140415092835.GA20951@omega \
--to=alex.aring@gmail.com \
--cc=ptxdist@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox