From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1WY9fg-0000P4-3N for ptxdist@pengutronix.de; Thu, 10 Apr 2014 09:45:16 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1WY9ff-0005pi-Vr for ptxdist@pengutronix.de; Thu, 10 Apr 2014 09:45:15 +0200 Date: Thu, 10 Apr 2014 09:45:15 +0200 From: Michael Olbrich Message-ID: <20140410074515.GE19292@pengutronix.de> References: <1396879709-14187-1-git-send-email-alex.aring@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1396879709-14187-1-git-send-email-alex.aring@gmail.com> Subject: Re: [ptxdist] [PATCH] powertop: disable native language support Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Mon, Apr 07, 2014 at 04:08:29PM +0200, Alexander Aring wrote: > This patch should fix a gettext issue and disable native language > support. I think that is a different issue, but the patch is a good idea anyways. > = > Original notice from powertop-2.5 "ABOUT-NLS" file: > = > "By default, this package will be installed to allow translation of > messages. It will automatically detect whether the system already > provides the GNU `gettext' functions. If not, the included GNU > `gettext' library will be used. This library is wholly contained > within this package, usually in the `intl/' subdirectory, so prior > installation of the GNU `gettext' package is _not_ required. > Installers may use special options at configuration time for changing > the default behaviour. The commands: > = > ./configure --with-included-gettext > ./configure --disable-nls > = > will, respectively, bypass any pre-existing `gettext' to use the > internationalizing routines provided within this package, or else, > _totally_ disable translation of messages." > = > This patch disable the native language support. We don't need such > support for translate messsages in another languages. The > documententation is somewhat outdated because there is no > "--with-included-gettext" option there. I hope --disable-nls should do > that also, then we don't need gettext anymore. > = > Also added arguments for "--without-libintl-prefix" and > "--without-libiconv-prefix". Making no sense with --disable-nls, but I saw > that in other rules as well. > = > Signed-off-by: Alexander Aring > Reported-by: J=FCrgen Beisert Thanks, applied. Michael > --- > rules/powertop.make | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > = > diff --git a/rules/powertop.make b/rules/powertop.make > index 36bc52a..6c376e0 100644 > --- a/rules/powertop.make > +++ b/rules/powertop.make > @@ -36,7 +36,10 @@ POWERTOP_LICENSE :=3D GPLv2 > POWERTOP_CONF_TOOL :=3D autoconf > POWERTOP_CONF_OPT :=3D \ > $(CROSS_AUTOCONF_USR) \ > - --$(call ptx/endis, PTXCONF_POWERTOP_PCI_SUPPORT)-pci > + --$(call ptx/endis, PTXCONF_POWERTOP_PCI_SUPPORT)-pci \ > + --disable-nls \ > + --without-libiconv-prefix \ > + --without-libintl-prefix > = > # ----------------------------------------------------------------------= ------ > # Target-Install > -- = > 1.9.1 > = > = > -- = > ptxdist mailing list > ptxdist@pengutronix.de -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- = ptxdist mailing list ptxdist@pengutronix.de