From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] net-snmp: clean up rule file
Date: Tue, 8 Apr 2014 17:43:27 +0200 [thread overview]
Message-ID: <20140408154327.GL31008@pengutronix.de> (raw)
In-Reply-To: <1396962831-27734-1-git-send-email-bth@kamstrup.dk>
On Tue, Apr 08, 2014 at 03:13:51PM +0200, Bruno Thomsen wrote:
> Signed-off-by: Bruno Thomsen <bth@kamstrup.dk>
> ---
> rules/net-snmp.make | 98 ++++++++-------------------------------------------
> 1 file changed, 14 insertions(+), 84 deletions(-)
>
> diff --git a/rules/net-snmp.make b/rules/net-snmp.make
> index 6ddb954..a2efc59 100644
> --- a/rules/net-snmp.make
> +++ b/rules/net-snmp.make
> @@ -60,91 +60,27 @@ NET_SNMP_AUTOCONF := \
> --disable-static \
> --$(call ptx/endis, PTXCONF_NET_SNMP_PRIVACY)-privacy \
> --disable-internal-md5 \
> + --with-endianness=$(call ptx/ifdef, PTXCONF_ENDIAN_LITTLE, little, big)
This line is missing '\' at the end.
The rest looks good.
Michael
> --$(call ptx/endis, PTXCONF_NET_SNMP_DOM_SOCK_ONLY)-agentx-dom-sock-only \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_MINI_AGENT)-mini-agent \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_AGENT)-agent \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_APPLICATIONS)-applications \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_SCRIPTS)-scripts \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_MIBS)-mibs \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_MIB_LOADING)-mib-loading \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_SNMPV1)-snmpv1 \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_SNMPV2C)-snmpv2c \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_DES)-des \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_MD5)-md5 \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_SNMPTRAPD)-snmptrapd-subagent \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_LOCAL_SMUX)-local-smux \
> + --$(call ptx/endis, PTXCONF_NET_SNMP_DEVELOPER)-developer \
> --enable-mib-config-checking \
> --enable-mfd-rewrites \
> --disable-testing-code \
> --disable-reentrant \
> --disable-ucd-snmp-compatibility
>
> -ifdef PTXCONF_ENDIAN_LITTLE
> -NET_SNMP_AUTOCONF += --with-endianness=little
> -else
> -NET_SNMP_AUTOCONF += --with-endianness=big
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_MINI_AGENT
> -NET_SNMP_AUTOCONF += --enable-mini-agent
> -else
> -NET_SNMP_AUTOCONF += --disable-mini-agent
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_AGENT
> -NET_SNMP_AUTOCONF += --enable-agent
> -else
> -NET_SNMP_AUTOCONF += --disable-agent
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_APPLICATIONS
> -NET_SNMP_AUTOCONF += --enable-applications
> -else
> -NET_SNMP_AUTOCONF += --disable-applications
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_SCRIPTS
> -NET_SNMP_AUTOCONF += --enable-scripts
> -else
> -NET_SNMP_AUTOCONF += --disable-scripts
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_MIBS
> -NET_SNMP_AUTOCONF += --enable-mibs
> -else
> -NET_SNMP_AUTOCONF += --disable-mibs
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_MIB_LOADING
> -NET_SNMP_AUTOCONF += --enable-mib-loading
> -else
> -NET_SNMP_AUTOCONF += --disable-mib-loading
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_SNMPV1
> -NET_SNMP_AUTOCONF += --enable-snmpv1
> -else
> -NET_SNMP_AUTOCONF += --disable-snmpv1
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_SNMPV2C
> -NET_SNMP_AUTOCONF += --enable-snmpv2c
> -else
> -NET_SNMP_AUTOCONF += --disable-snmpv2c
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_DES
> -NET_SNMP_AUTOCONF += --enable-des
> -else
> -NET_SNMP_AUTOCONF += --disable-des
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_MD5
> -NET_SNMP_AUTOCONF += --enable-md5
> -else
> -NET_SNMP_AUTOCONF += --disable-md5
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_SNMPTRAPD
> -NET_SNMP_AUTOCONF += --enable-snmptrapd-subagent
> -else
> -NET_SNMP_AUTOCONF += --disable-snmptrapd-subagent
> -endif
> -
> -ifdef PTXCONF_NET_SNMP_LOCAL_SMUX
> -NET_SNMP_AUTOCONF += --enable-local-smux
> -else
> -NET_SNMP_AUTOCONF += --disable-local-smux
> -endif
> -
> ifdef PTXCONF_NET_SNMP_FORCE_DEBUGGING
> NET_SNMP_AUTOCONF += --enable-debugging
> endif
> @@ -153,12 +89,6 @@ ifdef PTXCONF_NET_SNMP_STRIP_DEBUGGING
> NET_SNMP_AUTOCONF += --disable-debugging
> endif
>
> -ifdef PTXCONF_NET_SNMP_DEVELOPER
> -NET_SNMP_AUTOCONF += --enable-developer
> -else
> -NET_SNMP_AUTOCONF += --disable-developer
> -endif
> -
> NET_SNMP_MAKE_PAR := NO
>
> # ----------------------------------------------------------------------------
> --
> 1.7.9.5
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2014-04-08 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 13:13 Bruno Thomsen
2014-04-08 15:43 ` Michael Olbrich [this message]
2014-04-09 6:22 ` Bruno Thomsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408154327.GL31008@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox