From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1WVLTs-0002Z4-ID for ptxdist@pengutronix.de; Wed, 02 Apr 2014 15:45:28 +0200 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1WVLTs-0000o4-Fy for ptxdist@pengutronix.de; Wed, 02 Apr 2014 15:45:28 +0200 Date: Wed, 2 Apr 2014 15:45:28 +0200 From: Michael Olbrich Message-ID: <20140402134528.GA7950@pengutronix.de> References: <1396368155-27756-1-git-send-email-alex.aring@gmail.com> <1396368155-27756-4-git-send-email-alex.aring@gmail.com> <20140402091736.GH31118@pengutronix.de> <20140402103826.GA1779@x61s.campuswlan.hs-rm.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20140402103826.GA1779@x61s.campuswlan.hs-rm.de> Subject: Re: [ptxdist] [PATCH 3/3] powertop: add new package Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Wed, Apr 02, 2014 at 12:38:27PM +0200, Alexander Aring wrote: > On Wed, Apr 02, 2014 at 11:17:36AM +0200, Michael Olbrich wrote: > > On Tue, Apr 01, 2014 at 06:02:35PM +0200, Alexander Aring wrote: > > > This patch adds the new powertop package with pci support. > > > > > > Some notice by adding this package: > > > The pci support needs the pciutils package which provides the libpci. > > > This is the reason why we need a depends on !BUSYBOX_LSPCI there. The > > > pciutils packages can't be installed if BUSYBOX_LSPCI is selected. > > > > Just squash this in the first patch please. > ok. > > > > > > Signed-off-by: Alexander Aring > > > --- > > > rules/powertop.in | 42 ++++++++++++++++++++++++++++++++++++++ > > > rules/powertop.make | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 100 insertions(+) > > > create mode 100644 rules/powertop.in > > > create mode 100644 rules/powertop.make > > > > > > diff --git a/rules/powertop.in b/rules/powertop.in > > > new file mode 100644 > > > index 0000000..b1a4dbe > > > --- /dev/null > > > +++ b/rules/powertop.in > > > @@ -0,0 +1,42 @@ > > > +## SECTION=debug_tools > > > + > > > +menuconfig POWERTOP > > > + tristate > > > + prompt "powertop " > > > + select LIBNL3 > > > + select NCURSES > > > + select PCIUTILS if POWERTOP_PCI_SUPPORT > > > + select PCIUTILS_LIBPCI if POWERTOP_PCI_SUPPORT > > > + depends on !BUSYBOX_POWERTOP || ALLYES > > > + help > > > + PowerTOP is a Linux tool that finds the software > > > + component(s) that make your laptop use more power than > > > + necessary while it is idle. As of Linux kernel version > > > + 2.6.21, the kernel no longer has a fixed 1000Hz timer > > > + tick. This will (in theory) give a huge power savings > > > + because the CPU stays in low power mode for longer periods > > > + of time during system idle. > > > + > > > + However... there are many things that can ruin the party, > > > + both inside the kernel and in userspace. PowerTOP combines > > > + various sources of information from the kernel into one > > > + convenient screen so that you can see how well your system > > > + doing, and which components are the biggest problem. > > > + > > > +if POWERTOP > > > + > > > +config POWERTOP_PCI_SUPPORT > > > + bool > > > + prompt "pci support" > > > + depends on !BUSYBOX_LSPCI || ALLYES > > > + help > > > + This adds powertop support for the PCI bus. Should only be > > > + enabled if you have PCI support. > > > + > > > +comment "BusyBox' lspci is selected!" > > > + depends on BUSYBOX_LSPCI > > > > See my comment about that in my other mail > ok. > > > > > > + > > > +endif > > > + > > > +comment "BusyBox' powertop is selected!" > > > + depends on BUSYBOX_POWERTOP > > > diff --git a/rules/powertop.make b/rules/powertop.make > > > new file mode 100644 > > > index 0000000..a5554bc > > > --- /dev/null > > > +++ b/rules/powertop.make > > > @@ -0,0 +1,58 @@ > > > +# -*-makefile-*- > > > +# > > > +# Copyright (C) 2009 by Marc Kleine-Budde > > > +# 2014 by Alexander Aring > > > +# > > > +# See CREDITS for details about who has contributed to this project. > > > +# > > > +# For further information about the PTXdist project and license conditions > > > +# see the README file. > > > +# > > > + > > > +# > > > +# We provide this package > > > +# > > > +PACKAGES-$(PTXCONF_POWERTOP) += powertop > > > + > > > +# > > > +# Paths and names > > > +# > > > +POWERTOP_VERSION := 2.5 > > > +POWERTOP_MD5 := 806bbcbd44fcea1f807c9582fc1f7d3e > > > +POWERTOP := powertop-$(POWERTOP_VERSION) > > > +POWERTOP_SUFFIX := tar.gz > > > +POWERTOP_URL := https://01.org/sites/default/files/downloads/powertop/$(POWERTOP).$(POWERTOP_SUFFIX) > > > +POWERTOP_SOURCE := $(SRCDIR)/$(POWERTOP).$(POWERTOP_SUFFIX) > > > +POWERTOP_DIR := $(BUILDDIR)/$(POWERTOP) > > > +POWERTOP_LICENSE := GPLv2 > > > + > > > +# ---------------------------------------------------------------------------- > > > +# Prepare > > > +# ---------------------------------------------------------------------------- > > > + > > > +# > > > +# autoconf > > > +# > > > +POWERTOP_CONF_TOOL := autoconf > > > +POWERTOP_CONF_OPT := $(CROSS_AUTOCONF_USR) > > > > No usefull configure options? Remove this line in that case. > > > Yes no useful options here, useful options would be a --disable-pci or > --enable-pci explicit, but they search for pkgconfig files and enabled > it if they found some one. I think that's ok. Please add it. Otherwise you may get pci support or not when the option is disabled. That's not good. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de