Re: [ptxdist] [PATCH 3/3] powertop: add new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Apr 01, 2014 at 06:02:35PM +0200, Alexander Aring wrote:
> This patch adds the new powertop package with pci support.
> 
> Some notice by adding this package:
> The pci support needs the pciutils package which provides the libpci.
> This is the reason why we need a depends on !BUSYBOX_LSPCI there. The
> pciutils packages can't be installed if BUSYBOX_LSPCI is selected.

Just squash this in the first patch please.

> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
>  rules/powertop.in   | 42 ++++++++++++++++++++++++++++++++++++++
>  rules/powertop.make | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 100 insertions(+)
>  create mode 100644 rules/powertop.in
>  create mode 100644 rules/powertop.make
> 
> diff --git a/rules/powertop.in b/rules/powertop.in
> new file mode 100644
> index 0000000..b1a4dbe
> --- /dev/null
> +++ b/rules/powertop.in
> @@ -0,0 +1,42 @@
> +## SECTION=debug_tools
> +
> +menuconfig POWERTOP
> +	tristate
> +	prompt "powertop                      "
> +	select LIBNL3
> +	select NCURSES
> +	select PCIUTILS		if POWERTOP_PCI_SUPPORT
> +	select PCIUTILS_LIBPCI	if POWERTOP_PCI_SUPPORT
> +	depends on !BUSYBOX_POWERTOP || ALLYES
> +	help
> +	  PowerTOP is a Linux tool that finds the software
> +	  component(s) that make your laptop use more power than
> +	  necessary while it is idle. As of Linux kernel version
> +	  2.6.21, the kernel no longer has a fixed 1000Hz timer
> +	  tick. This will (in theory) give a huge power savings
> +	  because the CPU stays in low power mode for longer periods
> +	  of time during system idle.
> +
> +	  However... there are many things that can ruin the party,
> +	  both inside the kernel and in userspace. PowerTOP combines
> +	  various sources of information from the kernel into one
> +	  convenient screen so that you can see how well your system
> +	  doing, and which components are the biggest problem.
> +
> +if POWERTOP
> +
> +config POWERTOP_PCI_SUPPORT
> +	bool
> +	prompt "pci support"
> +	depends on !BUSYBOX_LSPCI || ALLYES
> +	help
> +	  This adds powertop support for the PCI bus. Should only be
> +	  enabled if you have PCI support.
> +
> +comment "BusyBox' lspci is selected!"
> +        depends on BUSYBOX_LSPCI

See my comment about that in my other mail.

> +
> +endif
> +
> +comment "BusyBox' powertop is selected!"
> +        depends on BUSYBOX_POWERTOP
> diff --git a/rules/powertop.make b/rules/powertop.make
> new file mode 100644
> index 0000000..a5554bc
> --- /dev/null
> +++ b/rules/powertop.make
> @@ -0,0 +1,58 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2009 by Marc Kleine-Budde <mkl@pengutronix.de>
> +#		2014 by Alexander Aring <aar@pengutronix.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_POWERTOP) += powertop
> +
> +#
> +# Paths and names
> +#
> +POWERTOP_VERSION	:= 2.5
> +POWERTOP_MD5		:= 806bbcbd44fcea1f807c9582fc1f7d3e
> +POWERTOP		:= powertop-$(POWERTOP_VERSION)
> +POWERTOP_SUFFIX		:= tar.gz
> +POWERTOP_URL		:= https://01.org/sites/default/files/downloads/powertop/$(POWERTOP).$(POWERTOP_SUFFIX)
> +POWERTOP_SOURCE		:= $(SRCDIR)/$(POWERTOP).$(POWERTOP_SUFFIX)
> +POWERTOP_DIR		:= $(BUILDDIR)/$(POWERTOP)
> +POWERTOP_LICENSE	:= GPLv2
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# autoconf
> +#
> +POWERTOP_CONF_TOOL	:= autoconf
> +POWERTOP_CONF_OPT	:= $(CROSS_AUTOCONF_USR)

No usefull configure options? Remove this line in that case.

Michael

> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/powertop.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, powertop)
> +	@$(call install_fixup, powertop,PRIORITY,optional)
> +	@$(call install_fixup, powertop,SECTION,base)
> +	@$(call install_fixup, powertop,AUTHOR,"Alexander Aring <aar@pengutronix.de>")
> +	@$(call install_fixup, powertop,DESCRIPTION,missing)
> +
> +	@$(call install_copy, powertop, 0, 0, 0755, -, /usr/sbin/powertop)
> +
> +	@$(call install_finish, powertop)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 1.9.1
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de