From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Tue, 1 Apr 2014 14:30:30 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Message-ID: <20140401123030.GC29751@pengutronix.de> References: <2600638.TXFjk7YaMQ@ws-stein> <5154092.4WVLzE0vXN@ws-stein> <20140401093730.GB29751@pengutronix.de> <5060757.6ak7jiQ6Yl@ws-stein> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5060757.6ak7jiQ6Yl@ws-stein> Subject: Re: [ptxdist] git ptx-patches fails Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: Alexander Stein Cc: Michael Olbrich , ptxdist@pengutronix.de Hello Alexander, On Tue, Apr 01, 2014 at 11:59:42AM +0200, Alexander Stein wrote: > On Tuesday 01 April 2014 11:37:30, Uwe Kleine-K=F6nig wrote: > > On Tue, Apr 01, 2014 at 11:24:52AM +0200, Alexander Stein wrote: > > > On Tuesday 01 April 2014 10:24:41, Uwe Kleine-K=F6nig wrote: > > > > On Mon, Mar 31, 2014 at 07:08:53PM +0200, Alexander Stein wrote: > > > > > On Saturday 29 March 2014, 10:28:54 wrote Michael Olbrich: > > > > > > On Thu, Mar 27, 2014 at 08:16:15AM +0100, Alexander Stein wrote: > > > > > > > I tried to use git ptx-patches fromwithin a package and notic= ed it doesn't work. > > > > > > > I could track down the problem to this command (from scripts/= git-ptx-patches): > > > > > > > > man git-format-patch | grep -q -e --notes > > > > > > > = > > > > > > > Executing this command manually results in this error message: > > > > > > > > Error executing formatting or display command. > > > > > > > > System command (cd "/usr/share/man" && (echo ".pl 11i"; /bi= n/bzip2 -c -d '/usr/share/man/man1/git-format-patch.1.bz2') | /usr/bin/gtbl= | /usr/bin/nroff -mandoc | less) exited with status 141. > > > > > > > > No manual entry for git-format-patch > > > > > > > = > > > > > > > Interestingly executing > > > > > > > > (cd "/usr/share/man" && (echo ".pl 11i"; /bin/bzip2 -c -d '= /usr/share/man/man1/git-format-patch.1.bz2') | /usr/bin/gtbl | /usr/bin/nro= ff -mandoc | less) | grep -q -e --notes > > > > > > > works as expected. I have no idea what's wrong here. > > > > > > = > > > > > > Maybe this is caused by some aliases or interactive/non-ineract= ive magic. > > > > > > Does it help to replace "man git-format-patch" with "git format= -patch > > > > > > --help" or "man -P cat git-format-patch"? > > > > > = > > > > > Unfortunately no :( > > > > > = > > > > > git format-patch --help | grep -q -e --notes > > > > > Error executing formatting or display command. > > > > > System command (cd "/usr/share/man" && (echo ".pl 11i"; /bin/bzip= 2 -c -d '/usr/share/man/man1/git-format-patch.1.bz2') | /usr/bin/gtbl | /us= r/bin/nroff -mandoc | /usr/bin/less) exited with status 141. > > > > > No manual entry for git-format-patch > > > > > = > > > > > $ man -P cat git-format-patch | grep -q -e --notes > > > > > Error executing formatting or display command. > > > > > System command (cd "/usr/share/man" && (echo ".pl 11i"; /bin/bzip= 2 -c -d '/usr/share/man/man1/git-format-patch.1.bz2') | /usr/bin/gtbl | /us= r/bin/nroff -mandoc | cat) exited with status 141. > > > > > No manual entry for git-format-patch > > > > Do you have git-format-patch's manpage, i.e. does > > > > = > > > > man git-format-patch > > > > = > > > > work? > > > = > > > Yep, that man page is installed. > > > = > > > > On bash, what happens on: > > > > = > > > > $ man -P cat git-format-patch | grep -q -e --notes > > > > $ echo ${PIPESTATUS[@]} > > > = > > > $ man -P cat git-format-patch | grep -q -e --notes > > > Error executing formatting or display command. > > > System command (cd "/usr/share/man" && (echo ".pl 11i"; /bin/bzip2 -c= -d '/usr/share/man/man1/git-format-patch.1.bz2') | /usr/bin/gtbl | /usr/bi= n/nroff -mandoc | cat) exited with status 141. > > > No manual entry for git-format-patch > > > $ echo ${PIPESTATUS[@]} > > > 1 0 > > > = > > > > Does > > > > = > > > > strace -f -o /tmp/lala man -P cat git-format-patch | grep -q -e --= notes > > > > = > > > > give any insights (e.g. where does the 141 come from?) > > > = > > > Somewhat. The 'culprit' is grep so far: > > > $ man -P cat git-format-patch | grep -q -e --notes > > > Error executing formatting or display command. > > > System command (cd "/usr/share/man" && (echo ".pl 11i"; /bin/bzip2 -c= -d '/usr/share/man/man1/git-format-patch.1.bz2') | /usr/bin/gtbl | /usr/bi= n/nroff -mandoc | cat) exited with status 141. > > > No manual entry for git-format-patch > > > $ man -P cat git-format-patch | grep -e --notes > > > [--[no-]cover-letter] [--quiet] [--notes[= =3D]] > > > --notes[=3D] > > > = > > > It seems grep slightly behaves differently when used with -q. It clos= es STDIN as soon as it detects the pattern. > > > But the closed pipe results in an EPIPE returned from write(2) within= cat which exits with an error. > > My man (from the Debian package man-db 2.6.2-1) doesn't show this > > behaviour. Is your version older or newer? > = > I don't think this is related to man (what's man-db BTW?) at all. man-db is the package that provides /usr/bin/man on Debian. Also man-db from Debian unstable (i.e. 2.6.6) is unaffected. > I think the versions of cat and grep behave differently. I have At least my grep also closes its input with -q and makes cat unhappy: $ { seq 1 2000 | cat; echo >&2 $?; } | grep -q 1 = 141 $ { seq 1 2000 | cat; echo >&2 $?; } | grep 1 > /dev/null 0 So I still think it's a man problem. Reading the output of strace -o /tmp/tralala man git-format-patch | grep -q -e --notes "my" man doesn't use system to render the manpage. At least it doesn't do any execvp and it opens /usr/share/man/man1/git-format-patch.1.gz itself. So again, what is your man version? > installed grep-2.16 and coreutils-8.21 (current Gentoo stable > versions). For completeness although I think its proven to be unrelated: grep 2.12-2 + coreutils 8.13-3.5 (i.e. Debian stable) Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | -- = ptxdist mailing list ptxdist@pengutronix.de