From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1WTp6E-0001mB-LD for ptxdist@pengutronix.de; Sat, 29 Mar 2014 09:58:46 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1WTp6E-0005jN-Jm for ptxdist@pengutronix.de; Sat, 29 Mar 2014 09:58:46 +0100 Date: Sat, 29 Mar 2014 09:58:46 +0100 From: Michael Olbrich Message-ID: <20140329085846.GZ10959@pengutronix.de> References: <1395394509-26734-1-git-send-email-alex.aring@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1395394509-26734-1-git-send-email-alex.aring@gmail.com> Subject: Re: [ptxdist] [PATCH v2] libgmp: always build shared library Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Fri, Mar 21, 2014 at 10:35:09AM +0100, Alexander Aring wrote: > This patch drops the config for shared or static library build of > libgmp. Instead we build always libgmp as a shared library. > > This fix also an issue with a missing -fPIC if we build the static library. > > Signed-off-by: Alexander Aring > --- > changes since v2: > - remove the rest of patches from the other series since we are sure we can > drop the static library support. This makes the handling of libraries > much easier. Thanks, applied, with some cleanups. Michael > > rules/libgmp.in | 20 +------------------- > rules/libgmp.make | 10 +++------- > 2 files changed, 4 insertions(+), 26 deletions(-) > > diff --git a/rules/libgmp.in b/rules/libgmp.in > index b7127f3..ec063ad 100644 > --- a/rules/libgmp.in > +++ b/rules/libgmp.in > @@ -2,28 +2,10 @@ > # > # rules/libgmp.in > # > -menuconfig LIBGMP > +config LIBGMP > tristate > prompt "libgmp " > help > Compiles the GNU Multiprecision libraries for your target system. > > See http://gmplib.org/ for info about it. > - > -if LIBGMP > - > -config LIBGMP_SHARED > - bool > - default y > - prompt "Create shared library" > - help > - Create a shared library and install it into /usr/lib > - > -config LIBGMP_STATIC > - bool > - prompt "Create static link library" > - help > - Create a static link library and install it into /usr/lib. > - Normally not needed. > - > -endif > diff --git a/rules/libgmp.make b/rules/libgmp.make > index 8e3b356..3c6b01c 100644 > --- a/rules/libgmp.make > +++ b/rules/libgmp.make > @@ -38,8 +38,8 @@ LIBGMP_ENV := $(CROSS_ENV) > # > LIBGMP_AUTOCONF := \ > $(CROSS_AUTOCONF_USR) \ > - --$(call ptx/endis, PTXCONF_LIBGMP_SHARED)-shared \ > - --$(call ptx/endis, PTXCONF_LIBGMP_STATIC)-static > + --enable-shared \ > + --disable-static > > # ---------------------------------------------------------------------------- > # Target-Install > @@ -54,12 +54,8 @@ $(STATEDIR)/libgmp.targetinstall: > @$(call install_fixup, libgmp,AUTHOR,"Carsten Schlote ") > @$(call install_fixup, libgmp,DESCRIPTION,missing) > > -ifdef PTXCONF_LIBGMP_SHARED > @$(call install_lib, libgmp, 0, 0, 0644, libgmp) > -endif > -ifdef PTXCONF_LIBGMP_STATIC > - @$(call install_copy, libgmp, 0, 0, 0644, -, /usr/lib/libgmp.la) > -endif > + > @$(call install_finish, libgmp) > > @$(call touch) > -- > 1.9.1 > > > -- > ptxdist mailing list > ptxdist@pengutronix.de > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de