From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1WQutN-0002q3-Sb
	for ptxdist@pengutronix.de; Fri, 21 Mar 2014 09:33:29 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1WQutN-0000fh-Qa
	for ptxdist@pengutronix.de; Fri, 21 Mar 2014 09:33:29 +0100
Date: Fri, 21 Mar 2014 09:33:29 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140321083329.GK23331@pengutronix.de>
References: <1395389064-5802-1-git-send-email-alex.aring@gmail.com>
	<1395389064-5802-4-git-send-email-alex.aring@gmail.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1395389064-5802-4-git-send-email-alex.aring@gmail.com>
Subject: Re: [ptxdist] [PATCH 4/4] libgmp: remove LIBGMP_STATIC menu entry
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Fri, Mar 21, 2014 at 09:04:24AM +0100, Alexander Aring wrote:
> We can have a option like "--disable-shared --disable-static" which
> builds a static library for me. This option makes no sense, instead
> doing a dependency switch on LIBGMP_SHARED by doing ptx/disen in the
> make rule.

No, remove both options and always use the shared lib.

Michael

> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
>  rules/libgmp.in   | 7 -------
>  rules/libgmp.make | 2 +-
>  2 files changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/rules/libgmp.in b/rules/libgmp.in
> index b7127f3..4872dcb 100644
> --- a/rules/libgmp.in
> +++ b/rules/libgmp.in
> @@ -19,11 +19,4 @@ config LIBGMP_SHARED
>  	help
>  	  Create a shared library and install it into /usr/lib
>  
> -config LIBGMP_STATIC
> -	bool
> -	prompt "Create static link library"
> -	help
> -	  Create a static link library and install it into /usr/lib.
> -	  Normally not needed.
> -
>  endif
> diff --git a/rules/libgmp.make b/rules/libgmp.make
> index 2a1e8be..feaa52e 100644
> --- a/rules/libgmp.make
> +++ b/rules/libgmp.make
> @@ -39,7 +39,7 @@ LIBGMP_ENV 	:= $(CROSS_ENV)
>  LIBGMP_AUTOCONF := \
>  	$(CROSS_AUTOCONF_USR) \
>  	--$(call ptx/endis, PTXCONF_LIBGMP_SHARED)-shared \
> -	--$(call ptx/endis, PTXCONF_LIBGMP_STATIC)-static \
> +	--$(call ptx/disen, PTXCONF_LIBGMP_SHARED)-static \
>  	--with-gnu-ld \
>  	--with-pic
>  
> -- 
> 1.9.1
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de