From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 4/4] libgmp: remove LIBGMP_STATIC menu entry
Date: Fri, 21 Mar 2014 09:33:29 +0100 [thread overview]
Message-ID: <20140321083329.GK23331@pengutronix.de> (raw)
In-Reply-To: <1395389064-5802-4-git-send-email-alex.aring@gmail.com>
On Fri, Mar 21, 2014 at 09:04:24AM +0100, Alexander Aring wrote:
> We can have a option like "--disable-shared --disable-static" which
> builds a static library for me. This option makes no sense, instead
> doing a dependency switch on LIBGMP_SHARED by doing ptx/disen in the
> make rule.
No, remove both options and always use the shared lib.
Michael
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> rules/libgmp.in | 7 -------
> rules/libgmp.make | 2 +-
> 2 files changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/rules/libgmp.in b/rules/libgmp.in
> index b7127f3..4872dcb 100644
> --- a/rules/libgmp.in
> +++ b/rules/libgmp.in
> @@ -19,11 +19,4 @@ config LIBGMP_SHARED
> help
> Create a shared library and install it into /usr/lib
>
> -config LIBGMP_STATIC
> - bool
> - prompt "Create static link library"
> - help
> - Create a static link library and install it into /usr/lib.
> - Normally not needed.
> -
> endif
> diff --git a/rules/libgmp.make b/rules/libgmp.make
> index 2a1e8be..feaa52e 100644
> --- a/rules/libgmp.make
> +++ b/rules/libgmp.make
> @@ -39,7 +39,7 @@ LIBGMP_ENV := $(CROSS_ENV)
> LIBGMP_AUTOCONF := \
> $(CROSS_AUTOCONF_USR) \
> --$(call ptx/endis, PTXCONF_LIBGMP_SHARED)-shared \
> - --$(call ptx/endis, PTXCONF_LIBGMP_STATIC)-static \
> + --$(call ptx/disen, PTXCONF_LIBGMP_SHARED)-static \
> --with-gnu-ld \
> --with-pic
>
> --
> 1.9.1
>
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2014-03-21 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 8:04 [ptxdist] [PATCH 1/4] libgmp: fix issue with missing -fPIC Alexander Aring
2014-03-21 8:04 ` [ptxdist] [PATCH 2/4] libgmp: add missing with-gnu-ld Alexander Aring
2014-03-21 8:34 ` Michael Olbrich
2014-03-21 8:53 ` Alexander Aring
2014-03-21 8:04 ` [ptxdist] [PATCH 3/4] libgmp: remove targetinstall of static lib Alexander Aring
2014-03-21 8:04 ` [ptxdist] [PATCH 4/4] libgmp: remove LIBGMP_STATIC menu entry Alexander Aring
2014-03-21 8:33 ` Michael Olbrich [this message]
2014-03-21 8:31 ` [ptxdist] [PATCH 1/4] libgmp: fix issue with missing -fPIC Michael Olbrich
2014-03-21 8:55 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321083329.GK23331@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox