From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1WPwGr-0008A8-RM
	for ptxdist@pengutronix.de; Tue, 18 Mar 2014 16:49:41 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1WPwGr-0005gn-Pu
	for ptxdist@pengutronix.de; Tue, 18 Mar 2014 16:49:41 +0100
Date: Tue, 18 Mar 2014 16:49:41 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140318154941.GF5223@pengutronix.de>
References: <1392902934-21165-1-git-send-email-andreas@biessmann.de>
	<5325CC34.7090409@biessmann.de>
	<480422b0110b4795448fed69277f72f9@bwalle.de>
	<532862AD.30201@biessmann.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <532862AD.30201@biessmann.de>
Subject: Re: [ptxdist] [PATCH] ptxdist: check vendor for ct-ng toolchain
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi,

On Tue, Mar 18, 2014 at 04:13:49PM +0100, Andreas Bie=DFmann wrote:
> thanks for your feedback.
> =

> On 18.03.14 10:07, Bernhard Walle wrote:
> > Hi,
> > =

> > since I'm also using ct-ng toolchains, I like that feature. However,
> > in my case CT_TOOLCHAIN_PKGVERSION was empty, so wouldn't it make sense
> > to add the line
> > =

> >    [ -z "$vendor_is" ] && vendor_is=3Dcrosstool-NG
> > =

> > after
> > =

> >   vendor_is=3D$(${ct_vendor_def} | sed -n -e 's/"//g' -e
> > 's/^CT_TOOLCHAIN_PKGVERSION=3D//p')
> > =

> > (sorry, I don't have the original patch in my mail box).
> =

> I think we should use the whole ct-ng version string. As you also
> mentioned we need some specific parsing then but I think it's worth.
> My intention for that patch was to identify our specific ct-ng builds
> which are tagged with a vendor string. But as you pointed out most ct-ng
> toolchains will not have this parameter set.
> I'd provide a reworked patch if some pengutronix guy (mol?) would
> indicate if such a ct-ng version check would be applied generally.

I'd be happy to apply it. It may some time, because testing something like
that takes a bit more time.

Michael

-- =

Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- =

ptxdist mailing list
ptxdist@pengutronix.de