Re: [ptxdist] [PATCH] ptxdist: check vendor for ct-ng toolchain

[Michael Olbrich <m.olbrich@pengutronix.de>]

Hi,

On Tue, Mar 18, 2014 at 04:13:49PM +0100, Andreas Bießmann wrote:
> thanks for your feedback.
> 
> On 18.03.14 10:07, Bernhard Walle wrote:
> > Hi,
> > 
> > since I'm also using ct-ng toolchains, I like that feature. However,
> > in my case CT_TOOLCHAIN_PKGVERSION was empty, so wouldn't it make sense
> > to add the line
> > 
> >    [ -z "$vendor_is" ] && vendor_is=crosstool-NG
> > 
> > after
> > 
> >   vendor_is=$(${ct_vendor_def} | sed -n -e 's/"//g' -e
> > 's/^CT_TOOLCHAIN_PKGVERSION=//p')
> > 
> > (sorry, I don't have the original patch in my mail box).
> 
> I think we should use the whole ct-ng version string. As you also
> mentioned we need some specific parsing then but I think it's worth.
> My intention for that patch was to identify our specific ct-ng builds
> which are tagged with a vendor string. But as you pointed out most ct-ng
> toolchains will not have this parameter set.
> I'd provide a reworked patch if some pengutronix guy (mol?) would
> indicate if such a ct-ng version check would be applied generally.

I'd be happy to apply it. It may some time, because testing something like
that takes a bit more time.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de