mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] tarballs from git URLs: git archive vs. git submodule
Date: Thu, 6 Mar 2014 19:03:31 +0100	[thread overview]
Message-ID: <20140306180330.GQ32080@pengutronix.de> (raw)
In-Reply-To: <bb2f1a35b8c4e783a9f59e2a90c9b9c3@idefix.lespocky.dyndns.org>

Hi,

On Mon, Mar 03, 2014 at 01:13:00PM +0100, Alexander Dahl wrote:
> while trying the local_src feature (local_src/${PACKAGE}.{PLATFORM})
> which is actually really cool, I came across a problem with the
> automatic tarball creation from Git URLs. ptxd_make_get.sh uses `git
> archive` for this purpose which does not support git submodules. There
> are several scripts around the web by people who needed this in the past
> and although there were feature requests and even patches years ago in
> git, it's still not included mainline. :-(
> 
> The possibilities I see are these:
> 
> * waiting probably very long for a new git release with git archive
> supporting submodules
> * replace the use of submodules in the repositories I want to use with
> something else, maybe git subtree
> * scripting this and change ptxd_make_get.sh which could be quite
> complicated

 * create a tarball for each repository and extract all in a custom extract
   stage.

Take a look at e.g. host-tz-database on how to handle multiple tarballs.

> For the third possibility: I would suggest cloning the repo with the
> --mirror option into a --bare repository almost like it's done now. Then
> do a `git clone --recursive` to a temporary folder followed by a
> checkout to the desired tag. Make a tarball from this clone and remove
> the directory right afterwards. The git url support was introduced in
> June 2013 by Michael Olbrich and not touch since. Did anyone try to
> improve it in any way? Would a change in the proposed direction have
> chances to be accepted by the ptxdist developers? It would make the code
> more complex I guess.

'git archive' always creates the exact same tarball. It's not that easy to
do the same thing manually. I'd like to avoid too much complexity here.
But I'd be open for a patch that puts the 'git archive' call in a separate
function. Then you only need to overwrite this function locally in your
BSP with a special version that handles submodules.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2014-03-06 18:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03 12:13 Alexander Dahl
2014-03-06 18:03 ` Michael Olbrich [this message]
2015-08-27 13:50   ` wim vinckier
2015-08-28  8:11   ` Wim Vinckier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140306180330.GQ32080@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox