From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10] ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72) (envelope-from ) id 1WLcO1-0005eU-PX for ptxdist@pengutronix.de; Thu, 06 Mar 2014 18:47:13 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80) (envelope-from ) id 1WLcO1-0002FC-OI for ptxdist@pengutronix.de; Thu, 06 Mar 2014 18:47:13 +0100 Date: Thu, 6 Mar 2014 18:47:13 +0100 From: Michael Olbrich Message-ID: <20140306174713.GL32080@pengutronix.de> References: <1393160492-30990-1-git-send-email-post@lespocky.de> <7ea0a51eded8d805debb90beb601796e@idefix.lespocky.dyndns.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7ea0a51eded8d805debb90beb601796e@idefix.lespocky.dyndns.org> Subject: Re: [ptxdist] [PATCH] libtar: add as new package Reply-To: ptxdist@pengutronix.de List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ptxdist-bounces@pengutronix.de Errors-To: ptxdist-bounces@pengutronix.de To: ptxdist@pengutronix.de On Wed, Feb 26, 2014 at 09:41:53AM +0100, Alexander Dahl wrote: > I had some problems with the get stage and git urls we already discussed > in IRC last week. This still occurs with the current ptxdist 2014.02.0 > release, so I describe what I found. > > Am 2014-02-23 14:01, schrieb Alexander Dahl: > > Git only I used the ptxdist mechanism for creating a tarball from a git > > clone in get stage. > > In this context I noticed a behavior of ptxdist I consider a bug. Let me > describe: > > We use collections here. If I mark the libtar package <*> in the config > everything builds fine. If I mark it in the config and [*] in the > collection there's no problem, too. However if I mark this package > in the config but leave it [ ] in the connection a manual call to the > get stage fails: > > > % ptxdist get libtar > > ---------------------------- > target: libtar-1.2.20.tar.gz > ---------------------------- > > > error: empty parameter to 'ptxd_make_get' > > make: *** > [/home/adahl/mnt/bagend-isys/Downloads/ptxdist_src_archive/libtar-1.2.20.tar.gz] > Error 1 > > > I didn't notice this behavior with ordinary packages getting their > tarball by HTTP, but this one is different, because it uses git and > builds the tarball from the local mirror. > > Maybe anyone has time to look into this. ;-) This should happen with all packages. You cannot 'get' a package that is not enabled. The tarball -> URL mapping only exists for enabled packages, so ptxd_make_get gets called with an empty URL and complains. Michael -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- ptxdist mailing list ptxdist@pengutronix.de