Re: [ptxdist] [PATCH] libtar: add as new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Feb 26, 2014 at 09:41:53AM +0100, Alexander Dahl wrote:
> I had some problems with the get stage and git urls we already discussed
> in IRC last week. This still occurs with the current ptxdist 2014.02.0
> release, so I describe what I found.
> 
> Am 2014-02-23 14:01, schrieb Alexander Dahl:
> > Git only I used the ptxdist mechanism for creating a tarball from a git
> > clone in get stage.
> 
> In this context I noticed a behavior of ptxdist I consider a bug. Let me
> describe:
> 
> We use collections here. If I mark the libtar package <*> in the config
> everything builds fine. If I mark it <m> in the config and [*] in the
> collection there's no problem, too. However if I mark this package <m>
> in the config but leave it [ ] in the connection a manual call to the
> get stage fails:
> 
> 
> % ptxdist get libtar
> 
> ----------------------------
> target: libtar-1.2.20.tar.gz
> ----------------------------
> 
> 
> error: empty parameter to 'ptxd_make_get'
> 
> make: ***
> [/home/adahl/mnt/bagend-isys/Downloads/ptxdist_src_archive/libtar-1.2.20.tar.gz]
> Error 1
> 
> 
> I didn't notice this behavior with ordinary packages getting their
> tarball by HTTP, but this one is different, because it uses git and
> builds the tarball from the local mirror.
> 
> Maybe anyone has time to look into this. ;-)

This should happen with all packages. You cannot 'get' a package that is
not enabled. The tarball -> URL mapping only exists for enabled packages,
so ptxd_make_get gets called with an empty URL and complains.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de