Re: [ptxdist] [PATCH v2 1/2] cxxtools: Add host package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Feb 18, 2014 at 08:09:17AM +0100, Bernhard Sessler wrote:
> Signed-off-by: Bernhard Sessler <bernhard.sessler@corscience.de>
> ---
>  rules/host-cxxtools.in   |  6 ++++++
>  rules/host-cxxtools.make | 38 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 44 insertions(+)
>  create mode 100644 rules/host-cxxtools.in
>  create mode 100644 rules/host-cxxtools.make
> 
> diff --git a/rules/host-cxxtools.in b/rules/host-cxxtools.in
> new file mode 100644
> index 0000000..b597311
> --- /dev/null
> +++ b/rules/host-cxxtools.in
> @@ -0,0 +1,6 @@
> +## SECTION=hosttools_noprompt
> +## SECTION=hosttools_platform

Don't add this to hosttools_platform.

> +
> +config HOST_CXXTOOLS
> +	tristate
> +	default ALLYES
> diff --git a/rules/host-cxxtools.make b/rules/host-cxxtools.make
> new file mode 100644
> index 0000000..abf93ca
> --- /dev/null
> +++ b/rules/host-cxxtools.make
> @@ -0,0 +1,38 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2014 by Bernhard Seßler <bernhard.sessler@corscience.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +HOST_PACKAGES-$(PTXCONF_HOST_CXXTOOLS) += host-cxxtools
> +
> +#
> +# Paths and names
> +#
> +HOST_CXXTOOLS_VERSION	:= 2.2.1
> +HOST_CXXTOOLS_MD5		:= aab00068ae5237435b37ac86f2ac7576
> +HOST_CXXTOOLS		:= cxxtools-$(HOST_CXXTOOLS_VERSION)
> +HOST_CXXTOOLS_SUFFIX	:= tar.gz
> +HOST_CXXTOOLS_URL		:= http://www.tntnet.org/download/$(HOST_CXXTOOLS).$(HOST_CXXTOOLS_SUFFIX)
> +HOST_CXXTOOLS_SOURCE	:= $(SRCDIR)/$(HOST_CXXTOOLS).$(HOST_CXXTOOLS_SUFFIX)
> +HOST_CXXTOOLS_DIR		:= $(HOST_BUILDDIR)/$(HOST_CXXTOOLS)

Only
HOST_CXXTOOLS_DIR	= $(HOST_BUILDDIR)/$(CXXTOOLS)
please. The rest is taken from the target package.

All my comments apply to host-tntnet as well.

Michael

> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +HOST_CXXTOOLS_CONF_TOOL	:= autoconf
> +HOST_CXXTOOLS_CONF_OPT	:= \
> +	$(HOST_AUTOCONF) \
> +	--disable-dependency-tracking \
> +	--disable-unittest \
> +	--disable-demos
> +
> +# vim: syntax=make
> -- 
> 1.8.3.2
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de