* [ptxdist] bug in ppp.make @ 2014-02-03 16:19 Bart Vanhaute 2014-02-04 8:50 ` Juergen Beisert 0 siblings, 1 reply; 3+ messages in thread From: Bart Vanhaute @ 2014-02-03 16:19 UTC (permalink / raw) To: ptxdist Hello, there is a typo in the ppp.make script to make the pppd SUID. At line 150, the ppp.make file tests for PTXCONFIG_PPP_SUID, but that should be PTXCONF_PPP_SUID. Thanks, Bart. -- ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] bug in ppp.make 2014-02-03 16:19 [ptxdist] bug in ppp.make Bart Vanhaute @ 2014-02-04 8:50 ` Juergen Beisert 2014-02-04 9:42 ` Bart Vanhaute 0 siblings, 1 reply; 3+ messages in thread From: Juergen Beisert @ 2014-02-04 8:50 UTC (permalink / raw) To: ptxdist; +Cc: Bart Vanhaute Hi Bart, On Monday 03 February 2014 17:19:56 Bart Vanhaute wrote: > there is a typo in the ppp.make script to make the pppd SUID. At line > 150, the ppp.make file tests for PTXCONFIG_PPP_SUID, but that should be > PTXCONF_PPP_SUID. You mean such a change? diff --git a/rules/ppp.make b/rules/ppp.make index d4d0171..f9c5917 100644 --- a/rules/ppp.make +++ b/rules/ppp.make @@ -147,7 +147,7 @@ $(STATEDIR)/ppp.targetinstall: @$(call install_fixup, ppp,AUTHOR,"Robert Schwebel (r.schwebel@pengutronix.de)") @$(call install_fixup, ppp,DESCRIPTION,missing) -ifdef PTXCONFIG_PPP_SUID +ifdef PTXCONF_PPP_SUID @$(call install_copy, ppp, 0, 0, 4755, -, /usr/sbin/pppd) else @$(call install_copy, ppp, 0, 0, 0755, -, /usr/sbin/pppd) :) Regards, Juergen -- Pengutronix e.K. | Juergen Beisert | Linux Solutions for Science and Industry | http://www.pengutronix.de/ | -- ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] bug in ppp.make 2014-02-04 8:50 ` Juergen Beisert @ 2014-02-04 9:42 ` Bart Vanhaute 0 siblings, 0 replies; 3+ messages in thread From: Bart Vanhaute @ 2014-02-04 9:42 UTC (permalink / raw) To: Juergen Beisert; +Cc: ptxdist On Tue, 2014-02-04 at 09:50 +0100, Juergen Beisert wrote: > Hi Bart, > > You mean such a change? > [..] Yes indeed. Thanks, Bart. -- ptxdist mailing list ptxdist@pengutronix.de ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-04 9:42 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-02-03 16:19 [ptxdist] bug in ppp.make Bart Vanhaute 2014-02-04 8:50 ` Juergen Beisert 2014-02-04 9:42 ` Bart Vanhaute
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox