From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
From: Juergen Beisert <jbe@pengutronix.de>
Date: Tue, 4 Feb 2014 09:50:44 +0100
References: <1391444396.5202.50.camel@sonar.punchtelematix.com>
In-Reply-To: <1391444396.5202.50.camel@sonar.punchtelematix.com>
MIME-Version: 1.0
Content-Disposition: inline
Message-Id: <201402040950.44754.jbe@pengutronix.de>
Subject: Re: [ptxdist] bug in ppp.make
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de
Cc: Bart Vanhaute <bart.vanhaute@trimbletl.com>

Hi Bart,

On Monday 03 February 2014 17:19:56 Bart Vanhaute wrote:
> there is a typo in the ppp.make script to make the pppd SUID. At line
> 150, the ppp.make file tests for PTXCONFIG_PPP_SUID, but that should be
> PTXCONF_PPP_SUID.

You mean such a change?

diff --git a/rules/ppp.make b/rules/ppp.make
index d4d0171..f9c5917 100644
--- a/rules/ppp.make
+++ b/rules/ppp.make
@@ -147,7 +147,7 @@ $(STATEDIR)/ppp.targetinstall:
        @$(call install_fixup, ppp,AUTHOR,"Robert Schwebel (r.schwebel@peng=
utronix.de)")
        @$(call install_fixup, ppp,DESCRIPTION,missing)

-ifdef PTXCONFIG_PPP_SUID
+ifdef PTXCONF_PPP_SUID
        @$(call install_copy, ppp, 0, 0, 4755, -, /usr/sbin/pppd)
 else
        @$(call install_copy, ppp, 0, 0, 0755, -, /usr/sbin/pppd)


:)

Regards,
Juergen

-- =

Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0| Juergen Beisert =A0 =A0 =A0 =A0 =A0 =A0 |
Linux Solutions for Science and Industry =A0 =A0 =A0| http://www.pengutroni=
x.de/  |

-- =

ptxdist mailing list
ptxdist@pengutronix.de