mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Juergen Beisert <jbe@pengutronix.de>
To: ptxdist@pengutronix.de
Cc: Bart Vanhaute <bart.vanhaute@trimbletl.com>
Subject: Re: [ptxdist] bug in ppp.make
Date: Tue, 4 Feb 2014 09:50:44 +0100	[thread overview]
Message-ID: <201402040950.44754.jbe@pengutronix.de> (raw)
In-Reply-To: <1391444396.5202.50.camel@sonar.punchtelematix.com>

Hi Bart,

On Monday 03 February 2014 17:19:56 Bart Vanhaute wrote:
> there is a typo in the ppp.make script to make the pppd SUID. At line
> 150, the ppp.make file tests for PTXCONFIG_PPP_SUID, but that should be
> PTXCONF_PPP_SUID.

You mean such a change?

diff --git a/rules/ppp.make b/rules/ppp.make
index d4d0171..f9c5917 100644
--- a/rules/ppp.make
+++ b/rules/ppp.make
@@ -147,7 +147,7 @@ $(STATEDIR)/ppp.targetinstall:
        @$(call install_fixup, ppp,AUTHOR,"Robert Schwebel (r.schwebel@pengutronix.de)")
        @$(call install_fixup, ppp,DESCRIPTION,missing)

-ifdef PTXCONFIG_PPP_SUID
+ifdef PTXCONF_PPP_SUID
        @$(call install_copy, ppp, 0, 0, 4755, -, /usr/sbin/pppd)
 else
        @$(call install_copy, ppp, 0, 0, 0755, -, /usr/sbin/pppd)


:)

Regards,
Juergen

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

  reply	other threads:[~2014-02-04  8:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 16:19 Bart Vanhaute
2014-02-04  8:50 ` Juergen Beisert [this message]
2014-02-04  9:42   ` Bart Vanhaute

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201402040950.44754.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=bart.vanhaute@trimbletl.com \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox