From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1WAEWo-0003ZZ-HL
	for ptxdist@pengutronix.de; Mon, 03 Feb 2014 09:05:14 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1WAEWo-0000YL-Fr
	for ptxdist@pengutronix.de; Mon, 03 Feb 2014 09:05:14 +0100
Date: Mon, 3 Feb 2014 09:05:14 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140203080514.GB28131@pengutronix.de>
References: <1391294571-31138-1-git-send-email-jon@ringle.org>
	<20140203070418.GU26766@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20140203070418.GU26766@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

Hi,

On Mon, Feb 03, 2014 at 08:04:18AM +0100, Uwe Kleine-K=F6nig wrote:
> On Sat, Feb 01, 2014 at 05:42:51PM -0500, jon@ringle.org wrote:
> > From: Jon Ringle <jringle@gridpoint.com>
> > =

> > Allow a git repo to be specified with ssh://*.git
> > =

> > Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> > ---
> >  scripts/lib/ptxd_make_get.sh |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > =

> > diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> > index 9f388dd..26b99d5 100644
> > --- a/scripts/lib/ptxd_make_get.sh
> > +++ b/scripts/lib/ptxd_make_get.sh
> > @@ -332,7 +332,7 @@ ptxd_make_get() {
> >  		shift
> >  =

> >  		case "${url}" in
> > -		git://*|http://*.git|https://*.git)
> > +		git://*|http://*.git|https://*.git|ssh://*.git)
> the more standard git-URL is:
> =

> 	hostname:/path/to/repo.git
> =

> maybe add that(, too| instead)?

No. It schould be clear that the URL is actually an URL, so it should start
with "<something>://". I wouln't mind adding more patterns, but only if the
URL cannot be expressed using the existing ones, e.g. file, or ftp URLs.

Michael

-- =

Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- =

ptxdist mailing list
ptxdist@pengutronix.de