From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git
Date: Mon, 3 Feb 2014 09:05:14 +0100 [thread overview]
Message-ID: <20140203080514.GB28131@pengutronix.de> (raw)
In-Reply-To: <20140203070418.GU26766@pengutronix.de>
Hi,
On Mon, Feb 03, 2014 at 08:04:18AM +0100, Uwe Kleine-König wrote:
> On Sat, Feb 01, 2014 at 05:42:51PM -0500, jon@ringle.org wrote:
> > From: Jon Ringle <jringle@gridpoint.com>
> >
> > Allow a git repo to be specified with ssh://*.git
> >
> > Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> > ---
> > scripts/lib/ptxd_make_get.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> > index 9f388dd..26b99d5 100644
> > --- a/scripts/lib/ptxd_make_get.sh
> > +++ b/scripts/lib/ptxd_make_get.sh
> > @@ -332,7 +332,7 @@ ptxd_make_get() {
> > shift
> >
> > case "${url}" in
> > - git://*|http://*.git|https://*.git)
> > + git://*|http://*.git|https://*.git|ssh://*.git)
> the more standard git-URL is:
>
> hostname:/path/to/repo.git
>
> maybe add that(, too| instead)?
No. It schould be clear that the URL is actually an URL, so it should start
with "<something>://". I wouln't mind adding more patterns, but only if the
URL cannot be expressed using the existing ones, e.g. file, or ftp URLs.
Michael
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
next prev parent reply other threads:[~2014-02-03 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-01 22:42 jon
2014-02-02 14:05 ` Alexander Dahl
2014-02-03 8:01 ` Michael Olbrich
2014-02-03 7:04 ` Uwe Kleine-König
2014-02-03 7:39 ` Alexander Dahl
2014-02-03 8:10 ` Uwe Kleine-König
2014-02-03 8:05 ` Michael Olbrich [this message]
2014-02-03 11:51 ` Jon Ringle
2014-02-03 8:05 ` Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140203080514.GB28131@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox