[ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git

[ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git

[jon]

From: Jon Ringle <jringle@gridpoint.com>

Allow a git repo to be specified with ssh://*.git

Signed-off-by: Jon Ringle <jringle@gridpoint.com>
---
 scripts/lib/ptxd_make_get.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
index 9f388dd..26b99d5 100644
--- a/scripts/lib/ptxd_make_get.sh
+++ b/scripts/lib/ptxd_make_get.sh
@@ -332,7 +332,7 @@ ptxd_make_get() {
 		shift
 
 		case "${url}" in
-		git://*|http://*.git|https://*.git)
+		git://*|http://*.git|https://*.git|ssh://*.git)
 			ptxd_make_get_download_permitted &&
 			ptxd_make_get_git && return
 			;;
-- 
1.7.10.4


-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git

[Alexander Dahl]

[-- Attachment #1.1: Type: text/plain, Size: 332 bytes --]

Hei hei,

>  		case "${url}" in
> -		git://*|http://*.git|https://*.git)
> +		git://*|http://*.git|https://*.git|ssh://*.git)
>  			ptxd_make_get_download_permitted &&
>  			ptxd_make_get_git && return
>  			;;

Does this mean one could use git in get stage? Is this documented
somewhere how to use it?

Greets
Alex


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]

[-- Attachment #2: Type: text/plain, Size: 48 bytes --]

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git

[Uwe Kleine-König]

Hello Jon,

On Sat, Feb 01, 2014 at 05:42:51PM -0500, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
> 
> Allow a git repo to be specified with ssh://*.git
> 
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> ---
>  scripts/lib/ptxd_make_get.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> index 9f388dd..26b99d5 100644
> --- a/scripts/lib/ptxd_make_get.sh
> +++ b/scripts/lib/ptxd_make_get.sh
> @@ -332,7 +332,7 @@ ptxd_make_get() {
>  		shift
>  
>  		case "${url}" in
> -		git://*|http://*.git|https://*.git)
> +		git://*|http://*.git|https://*.git|ssh://*.git)
the more standard git-URL is:

	hostname:/path/to/repo.git

maybe add that(, too| instead)?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git

[Alexander Dahl]

Hei hei, 

Am 2014-02-03 08:04, schrieb Uwe Kleine-König:
> the more standard git-URL is:
> 
> 	hostname:/path/to/repo.git

It's more an alternative than the standard. ;-)

> maybe add that(, too| instead)?

Maybe one could check the full list of supported URL syntax:

https://www.kernel.org/pub/software/scm/git/docs/git-push.html#URLS

Greets
Alex

-- 
»With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.« (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git

[Michael Olbrich]

Hi,

On Sun, Feb 02, 2014 at 03:05:53PM +0100, Alexander Dahl wrote:
> >  		case "${url}" in
> > -		git://*|http://*.git|https://*.git)
> > +		git://*|http://*.git|https://*.git|ssh://*.git)
> >  			ptxd_make_get_download_permitted &&
> >  			ptxd_make_get_git && return
> >  			;;
> 
> Does this mean one could use git in get stage? Is this documented
> somewhere how to use it?

I don't think it's documented anywhere. You can use it if you know what
you're doing (tm). PTXdist still only sees a tarball and a git url just
means that the tarball is created locally. So you cannot follow a branch,
but only use a specific revision. git URLs have a mandatory 'tag' parameter
to specify that.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git

[Michael Olbrich]

Hi,

On Mon, Feb 03, 2014 at 08:04:18AM +0100, Uwe Kleine-König wrote:
> On Sat, Feb 01, 2014 at 05:42:51PM -0500, jon@ringle.org wrote:
> > From: Jon Ringle <jringle@gridpoint.com>
> > 
> > Allow a git repo to be specified with ssh://*.git
> > 
> > Signed-off-by: Jon Ringle <jringle@gridpoint.com>
> > ---
> >  scripts/lib/ptxd_make_get.sh |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> > index 9f388dd..26b99d5 100644
> > --- a/scripts/lib/ptxd_make_get.sh
> > +++ b/scripts/lib/ptxd_make_get.sh
> > @@ -332,7 +332,7 @@ ptxd_make_get() {
> >  		shift
> >  
> >  		case "${url}" in
> > -		git://*|http://*.git|https://*.git)
> > +		git://*|http://*.git|https://*.git|ssh://*.git)
> the more standard git-URL is:
> 
> 	hostname:/path/to/repo.git
> 
> maybe add that(, too| instead)?

No. It schould be clear that the URL is actually an URL, so it should start
with "<something>://". I wouln't mind adding more patterns, but only if the
URL cannot be expressed using the existing ones, e.g. file, or ftp URLs.

Michael

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git

[Michael Olbrich]

On Sat, Feb 01, 2014 at 05:42:51PM -0500, jon@ringle.org wrote:
> From: Jon Ringle <jringle@gridpoint.com>
> 
> Allow a git repo to be specified with ssh://*.git
> 
> Signed-off-by: Jon Ringle <jringle@gridpoint.com>

Thanks, applied.

Michael

> ---
>  scripts/lib/ptxd_make_get.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
> index 9f388dd..26b99d5 100644
> --- a/scripts/lib/ptxd_make_get.sh
> +++ b/scripts/lib/ptxd_make_get.sh
> @@ -332,7 +332,7 @@ ptxd_make_get() {
>  		shift
>  
>  		case "${url}" in
> -		git://*|http://*.git|https://*.git)
> +		git://*|http://*.git|https://*.git|ssh://*.git)
>  			ptxd_make_get_download_permitted &&
>  			ptxd_make_get_git && return
>  			;;
> -- 
> 1.7.10.4
> 
> 
> -- 
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git

[Uwe Kleine-König]

On Mon, Feb 03, 2014 at 08:39:53AM +0100, Alexander Dahl wrote:
> Hei hei, 
> 
> Am 2014-02-03 08:04, schrieb Uwe Kleine-König:
> > the more standard git-URL is:
> > 
> > 	hostname:/path/to/repo.git
> 
> It's more an alternative than the standard. ;-)
Reading https://lkml.org/lkml/2007/2/14/135 makes me think that at least
Linus considers hostname:/path/to/repo.git to be the standard.

> > maybe add that(, too| instead)?
> 
> Maybe one could check the full list of supported URL syntax:
> 
> https://www.kernel.org/pub/software/scm/git/docs/git-push.html#URLS
I'd not add rsync and ftp as these are dumb. But other than that it
sounds like a good idea.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

-- 
ptxdist mailing list
ptxdist@pengutronix.de

Re: [ptxdist] [PATCH] ptxd_make_get.sh: handle ssh://*.git

[Jon Ringle]

> On Feb 3, 2014, at 2:04 AM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> 
> Hello Jon,
> 
>> On Sat, Feb 01, 2014 at 05:42:51PM -0500, jon@ringle.org wrote:
>> From: Jon Ringle <jringle@gridpoint.com>
>> 
>> Allow a git repo to be specified with ssh://*.git
>> 
>> Signed-off-by: Jon Ringle <jringle@gridpoint.com>
>> ---
>> scripts/lib/ptxd_make_get.sh |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh
>> index 9f388dd..26b99d5 100644
>> --- a/scripts/lib/ptxd_make_get.sh
>> +++ b/scripts/lib/ptxd_make_get.sh
>> @@ -332,7 +332,7 @@ ptxd_make_get() {
>>        shift
>> 
>>        case "${url}" in
>> -        git://*|http://*.git|https://*.git)
>> +        git://*|http://*.git|https://*.git|ssh://*.git)
> the more standard git-URL is:
> 
>    hostname:/path/to/repo.git
> 
> maybe add that(, too| instead)?
> 
Both ssh://hostname/path/to/repo.git and hostname:/path/to/repo.git are equivalent and use ssh for the transport. But I think in ptxdist we want to show explicitly what kind of URL is being used.

Jon
-- 
ptxdist mailing list
ptxdist@pengutronix.de