* [ptxdist] [PATCH] Valgrind requires a kernel version to work
@ 2013-12-20 11:41 Jürgen Beisert
2014-01-13 7:56 ` [ptxdist] [PATCH] Bridge-utils requires a kernel version to build Jürgen Beisert
0 siblings, 1 reply; 3+ messages in thread
From: Jürgen Beisert @ 2013-12-20 11:41 UTC (permalink / raw)
To: ptxdist
Until a kernel version is defined the Valgrind's prepare stage fails.
As this failure is due to an incomplete project configuration, add a more
helpful error message how to resolve it.
Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
diff --git a/rules/valgrind.make b/rules/valgrind.make
index 6ee7dd9..5869e47 100644
--- a/rules/valgrind.make
+++ b/rules/valgrind.make
@@ -45,6 +45,16 @@ VALGRIND_ENV := \
$(CROSS_ENV) \
valgrind_cv_sys_kernel_version=$(VALGRIND_KERNEL_VERSION)
+ifdef PTXCONF_VALGRIND
+ifeq ($(VALGRIND_KERNEL_VERSION),)
+ $(warning ######################### ERROR ################################)
+ $(warning # Linux kernel version required in order to make valgrind work #)
+ $(warning # Define a platform kernel or the kernel headers #)
+ $(warning ################################################################)
+ $(error )
+endif
+endif
+
#
# autoconf
#
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* [ptxdist] [PATCH] Bridge-utils requires a kernel version to build
2013-12-20 11:41 [ptxdist] [PATCH] Valgrind requires a kernel version to work Jürgen Beisert
@ 2014-01-13 7:56 ` Jürgen Beisert
2014-01-23 17:04 ` Michael Olbrich
0 siblings, 1 reply; 3+ messages in thread
From: Jürgen Beisert @ 2014-01-13 7:56 UTC (permalink / raw)
To: ptxdist
Until a kernel version is defined the bridge-utils' prepare stage fails.
As this failure is due to an incomplete project configuration, add a more
helpful error message how to resolve it.
Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
diff --git a/rules/bridge-utils.make b/rules/bridge-utils.make
index 9de1c16..f4b1402 100644
--- a/rules/bridge-utils.make
+++ b/rules/bridge-utils.make
@@ -40,6 +40,16 @@ BRIDGE_UTILS_AUTOCONF := \
$(CROSS_AUTOCONF_USR) \
--with-linux-headers=$(KERNEL_HEADERS_DIR)
+ifdef PTXCONF_BRIDGE_UTILS
+ifeq ($(KERNEL_HEADER_VERSION),)
+ $(warning ########################### ERROR ##################################)
+ $(warning # Linux kernel version required in order to make bridge-utils work #)
+ $(warning # Define a platform kernel or the kernel headers #)
+ $(warning ####################################################################)
+ $(error )
+endif
+endif
+
# ----------------------------------------------------------------------------
# Target-Install
# ----------------------------------------------------------------------------
--
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [ptxdist] [PATCH] Bridge-utils requires a kernel version to build
2014-01-13 7:56 ` [ptxdist] [PATCH] Bridge-utils requires a kernel version to build Jürgen Beisert
@ 2014-01-23 17:04 ` Michael Olbrich
0 siblings, 0 replies; 3+ messages in thread
From: Michael Olbrich @ 2014-01-23 17:04 UTC (permalink / raw)
To: ptxdist
On Mon, Jan 13, 2014 at 08:56:05AM +0100, Jürgen Beisert wrote:
> Until a kernel version is defined the bridge-utils' prepare stage fails.
> As this failure is due to an incomplete project configuration, add a more
> helpful error message how to resolve it.
I think this check should go to kernel-headers.make. A valid version is
always needed when kernel-headers are enabled.
Michael
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
>
> diff --git a/rules/bridge-utils.make b/rules/bridge-utils.make
> index 9de1c16..f4b1402 100644
> --- a/rules/bridge-utils.make
> +++ b/rules/bridge-utils.make
> @@ -40,6 +40,16 @@ BRIDGE_UTILS_AUTOCONF := \
> $(CROSS_AUTOCONF_USR) \
> --with-linux-headers=$(KERNEL_HEADERS_DIR)
>
> +ifdef PTXCONF_BRIDGE_UTILS
> +ifeq ($(KERNEL_HEADER_VERSION),)
> + $(warning ########################### ERROR ##################################)
> + $(warning # Linux kernel version required in order to make bridge-utils work #)
> + $(warning # Define a platform kernel or the kernel headers #)
> + $(warning ####################################################################)
> + $(error )
> +endif
> +endif
> +
> # ----------------------------------------------------------------------------
> # Target-Install
> # ----------------------------------------------------------------------------
>
> --
> Pengutronix e.K. | Juergen Beisert |
> Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-23 17:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-20 11:41 [ptxdist] [PATCH] Valgrind requires a kernel version to work Jürgen Beisert
2014-01-13 7:56 ` [ptxdist] [PATCH] Bridge-utils requires a kernel version to build Jürgen Beisert
2014-01-23 17:04 ` Michael Olbrich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox