From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <ptxdist-bounces@pengutronix.de>
Received: from ptx.hi.pengutronix.de ([2001:6f8:1178:2:5054:ff:fec0:8e10]
	ident=Debian-exim) by metis.ext.pengutronix.de with esmtp (Exim 4.72)
	(envelope-from <mol@pengutronix.de>) id 1W6Nhb-00071i-GZ
	for ptxdist@pengutronix.de; Thu, 23 Jan 2014 18:04:27 +0100
Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.80)
	(envelope-from <mol@pengutronix.de>) id 1W6Nhb-0001wS-F5
	for ptxdist@pengutronix.de; Thu, 23 Jan 2014 18:04:27 +0100
Date: Thu, 23 Jan 2014 18:04:27 +0100
From: Michael Olbrich <m.olbrich@pengutronix.de>
Message-ID: <20140123170427.GA7351@pengutronix.de>
References: <201312201241.12949.jbe@pengutronix.de>
	<201401130856.05369.jbe@pengutronix.de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <201401130856.05369.jbe@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] Bridge-utils requires a kernel version to
	build
Reply-To: ptxdist@pengutronix.de
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/pipermail/ptxdist>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
	<mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Sender: ptxdist-bounces@pengutronix.de
Errors-To: ptxdist-bounces@pengutronix.de
To: ptxdist@pengutronix.de

On Mon, Jan 13, 2014 at 08:56:05AM +0100, J=FCrgen Beisert wrote:
> Until a kernel version is defined the bridge-utils' prepare stage fails.
> As this failure is due to an incomplete project configuration, add a more =

> helpful error message how to resolve it.

I think this check should go to kernel-headers.make. A valid version is
always needed when kernel-headers are enabled.

Michael

> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
> =

> diff --git a/rules/bridge-utils.make b/rules/bridge-utils.make
> index 9de1c16..f4b1402 100644
> --- a/rules/bridge-utils.make
> +++ b/rules/bridge-utils.make
> @@ -40,6 +40,16 @@ BRIDGE_UTILS_AUTOCONF :=3D \
>  	$(CROSS_AUTOCONF_USR) \
>  	--with-linux-headers=3D$(KERNEL_HEADERS_DIR)
>  =

> +ifdef PTXCONF_BRIDGE_UTILS
> +ifeq ($(KERNEL_HEADER_VERSION),)
> + $(warning ########################### ERROR ###########################=
#######)
> + $(warning # Linux kernel version required in order to make bridge-utils=
 work #)
> + $(warning #        Define a platform kernel or the kernel headers      =
      #)
> + $(warning #############################################################=
#######)
> + $(error )
> +endif
> +endif
> +
>  # ----------------------------------------------------------------------=
------
>  # Target-Install
>  # ----------------------------------------------------------------------=
------
> =

> -- =

> Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0| Juergen Beisert =A0 =A0 =A0 =A0 =A0 =A0 |
> Linux Solutions for Science and Industry =A0 =A0 =A0| http://www.pengutro=
nix.de/  |
> =

> -- =

> ptxdist mailing list
> ptxdist@pengutronix.de
> =


-- =

Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

-- =

ptxdist mailing list
ptxdist@pengutronix.de