From: Michael Olbrich <m.olbrich@pengutronix.de>
To: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] Bridge-utils requires a kernel version to build
Date: Thu, 23 Jan 2014 18:04:27 +0100 [thread overview]
Message-ID: <20140123170427.GA7351@pengutronix.de> (raw)
In-Reply-To: <201401130856.05369.jbe@pengutronix.de>
On Mon, Jan 13, 2014 at 08:56:05AM +0100, Jürgen Beisert wrote:
> Until a kernel version is defined the bridge-utils' prepare stage fails.
> As this failure is due to an incomplete project configuration, add a more
> helpful error message how to resolve it.
I think this check should go to kernel-headers.make. A valid version is
always needed when kernel-headers are enabled.
Michael
> Signed-off-by: Juergen Beisert <jbe@pengutronix.de>
>
> diff --git a/rules/bridge-utils.make b/rules/bridge-utils.make
> index 9de1c16..f4b1402 100644
> --- a/rules/bridge-utils.make
> +++ b/rules/bridge-utils.make
> @@ -40,6 +40,16 @@ BRIDGE_UTILS_AUTOCONF := \
> $(CROSS_AUTOCONF_USR) \
> --with-linux-headers=$(KERNEL_HEADERS_DIR)
>
> +ifdef PTXCONF_BRIDGE_UTILS
> +ifeq ($(KERNEL_HEADER_VERSION),)
> + $(warning ########################### ERROR ##################################)
> + $(warning # Linux kernel version required in order to make bridge-utils work #)
> + $(warning # Define a platform kernel or the kernel headers #)
> + $(warning ####################################################################)
> + $(error )
> +endif
> +endif
> +
> # ----------------------------------------------------------------------------
> # Target-Install
> # ----------------------------------------------------------------------------
>
> --
> Pengutronix e.K. | Juergen Beisert |
> Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
>
> --
> ptxdist mailing list
> ptxdist@pengutronix.de
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
ptxdist mailing list
ptxdist@pengutronix.de
prev parent reply other threads:[~2014-01-23 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 11:41 [ptxdist] [PATCH] Valgrind requires a kernel version to work Jürgen Beisert
2014-01-13 7:56 ` [ptxdist] [PATCH] Bridge-utils requires a kernel version to build Jürgen Beisert
2014-01-23 17:04 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123170427.GA7351@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox